Serve UI extension source maps during app dev - #8260
Merged
Conversation
The built bundle ends with a relative `//# sourceMappingURL=<handle>.js.map`, so the browser requests the map next to the asset's own URL — `/assets/<target>/<handle>.js.map` — a key no asset payload emits. The request 404'd and DevTools only ever showed minified output. Register that key on the asset resolver when the map exists, and serve `.js.map` requests from the extension directory. Maps are deliberately absent from the bundle: `keepBuiltSourcemapsLocally` moves them back into the extension directory so `.js.map` files never reach a deploy bundle. No build step changes, so that invariant is untouched. Unregistered `.js.map` paths 404, keeping the resolver the allowlist for this route. Assisted-By: devx/5a367c53-dfe0-42d0-8b9f-5258f54d589a
craigmichaelmartin
approved these changes
Aug 6, 2026
craigmichaelmartin
added a commit
that referenced
this pull request
Aug 7, 2026
The push event from merging #8260 never triggered the Release workflow, so the Version Packages PR for 4.6.1 was not created. Empty commit to re-deliver the push trigger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built bundle ends with a relative
//# sourceMappingURL=<handle>.js.map, so the browser requests the map next to the asset's own URL —/assets/<target>/<handle>.js.map— a key no asset payload emits. The request 404'd and DevTools only ever showed minified output.Register that key on the asset resolver when the map exists, and serve
.js.maprequests from the extension directory. Maps are deliberately absent from the bundle:keepBuiltSourcemapsLocallymoves them back into the extension directory so.js.mapfiles never reach a deploy bundle. No build step changes, so that invariant is untouched.Unregistered
.js.mappaths 404, keeping the resolver the allowlist for this route.Assisted-By: devx/5a367c53-dfe0-42d0-8b9f-5258f54d589a