Ask about demo data when creating a dev store interactively - #8459
Merged
Conversation
4 tasks
nickwesselman
force-pushed
the
nick/dev-store-demo-data-prompt
branch
2 times, most recently
from
September 2, 2026 18:33
f0acab5 to
fb5f5cc
Compare
nickwesselman
force-pushed
the
nick/dev-store-demo-data-prompt
branch
from
September 2, 2026 18:49
fb5f5cc to
ef68bf4
Compare
nickwesselman
force-pushed
the
nick/dev-store-demo-data-prompt
branch
from
September 2, 2026 18:52
ef68bf4 to
5a0db4e
Compare
amcaplan
reviewed
Sep 2, 2026
| message: 'Populate the store with demo data?', | ||
| confirmationMessage: 'Yes, add demo data', | ||
| cancellationMessage: 'No, start with an empty store', | ||
| defaultValue: true, |
Contributor
There was a problem hiding this comment.
The CLI defaults to no demo data; it's an opt-in. Here it's phrased as an opt-out. Do we want to align the two experiences?
Contributor
Author
There was a problem hiding this comment.
I think we should encourage new users to use it.
nickwesselman
force-pushed
the
nick/dev-store-demo-data-prompt
branch
2 times, most recently
from
September 2, 2026 20:29
b5c7729 to
a8ab9ce
Compare
4 tasks
amcaplan
approved these changes
Sep 2, 2026
amcaplan
left a comment
Contributor
There was a problem hiding this comment.
I'm ambivalent about the whole idea, but I can live with it.
nickwesselman
force-pushed
the
nick/dev-store-demo-data-prompt
branch
from
September 2, 2026 21:17
a8ab9ce to
93e375a
Compare
Add a shared `devStoreDemoDataPrompt` and ask it after the name and plan prompts, so an interactively created dev store can be populated with demo data without leaving the CLI. Rename `--with-demo-data` to `--demo-data` with `allowNo`, giving the flag the standard tri-state behavior: `--demo-data` and `--no-demo-data` answer the question outright, while an unspecified flag prompts in an interactive terminal and defaults to false everywhere else. `app dev` has no demo data flag and rejects non-TTY runs upstream, so it always asks, on both the zero-store and store-picker creation paths. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-By: devx/a27b4557-3ac8-448a-8860-7a5ed6b20687
nickwesselman
force-pushed
the
nick/dev-store-demo-data-prompt
branch
from
September 2, 2026 21:20
93e375a to
82de102
Compare
Contributor
|
| Command | Flag |
|---|---|
store:create:dev |
--with-demo-data |
🔧 Removed Environment Variables
The following env vars are no longer referenced in command flags:
| Env Var | Previously Used By |
|---|---|
SHOPIFY_FLAG_STORE_WITH_DEMO_DATA |
store:create:dev --with-demo-data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
shopify store create devcan already populate a new store with demo data through--with-demo-data, but nothing ever asks about it. A developer creating a storeinteractively — including through the inline creation flow that #8323 and #8397 just
added to
app dev— gets an empty store and no indication that demo data was anoption.
WHAT is this pull request doing?
Adds a demo data question to interactive dev store creation, asked after the name and
plan prompts.
New shared
devStoreDemoDataPromptin@shopify/organizations, next to the existingname and plan prompts, re-exported as
storeDemoDataPrompt(store) anddevStoreDemoDataPrompt(app) through the same thin delegates those two already use."Yes, add demo data" is preselected.
store create devgives the flag the standard tri-state behavior.--with-demo-dataisrenamed to
--demo-dataand gainsallowNo, so:--demo-dataand--no-demo-dataanswer the question outright and skip the prompt. Anunspecified flag prompts in an interactive terminal and defaults to
falsein anon-interactive one, using the same
terminalSupportsPrompting()check thatrequiredIfNonInteractiveenforcement uses.SHOPIFY_FLAG_STORE_DEMO_DATAcounts asspecified, so it also skips the prompt.
app devhas no demo data flag and rejects non-TTY runs upstream, so it always asks,on both the zero-store and store-picker creation paths.
One note for reviewers:
--with-demo-datais renamed rather than aliased. The command ishidden, and the flag only reachedmainalongside the unreleased inline creation work, sono documented workflow should depend on the old spelling. Say the word if you would rather
keep
--with-demo-dataas a hidden alias.How to test your changes?
shopify store create dev --organization-id <id> --name test-store --plan basicin aterminal — asks "Populate the store with demo data?" with Yes preselected.
--demo-dataor--no-demo-data— no question, and the created storereflects the flag.
CI=1) — no question, demo data off.shopify app dev --resetin an App Management organization, then either accept thezero-store creation flow or pick "Create a new dev store" from the picker — name, plan,
then the demo data question, and the created store reflects the answer.
Tophat: the
app devpath was exercised locally end to end (name, plan, demo dataquestion, store created, dev started). The
store create devflag-gating paths arecovered by unit tests but were not live-tophatted.
Changelog
No changeset. This builds on the inline dev store creation from #8323 and #8397, which is
not released yet, so the whole flow will be covered by a single changelog entry rather than
one per PR in this stack.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add— intentionally omitted, see Changelog above