Show store list context in an info banner - #8467
Merged
Merged
Conversation
The organization line and the `shopify store auth list` hint were printed as bare stdout text, so the hint collided with the bottom of the table and the organization had no visual separation from the header row. Move both into a single info banner rendered above the table, matching the banner-then-table shape `listBulkOperations` already uses in this package. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-By: devx/4874be33-ff52-4bcc-beaa-5ff567199ec5
Move the organization out of the headline into a tabular customSection,
matching the label/value shape used by `store info` and the dev store
creation summary. Custom sections lay out with gap={1}, so the row and the
auth hint separate cleanly.
Route the empty states through the same banner. They previously printed as
bare multi-line text, stated the organization three different ways, and
phrased the auth hint differently from the populated path.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Assisted-By: devx/4874be33-ff52-4bcc-beaa-5ff567199ec5
amcaplan
approved these changes
Sep 3, 2026
amcaplan
left a comment
amcaplan
left a comment
Contributor
There was a problem hiding this comment.
I just removed unnecessary comments (IMO) in commit 52c69fe44da2ffec54ada4cbcabb60dd54fdea58, otherwise we're good to go. Tophatted and it looks great!
|
|
||
| // The banner pads every line out to the terminal width, which is narrow in the test environment. | ||
| // Trimming keeps the snapshots readable and free of trailing whitespace. | ||
| function trimmedLines(output: string): string { |
Contributor
There was a problem hiding this comment.
Very cool. Maybe worth broadening to the full test suite as a util in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
shopify store listprinted its context as bare stdout text around the table. Theshopify store auth listhint ends up flush against the last table row, and the organization line sits directly on top of the header with no separation:WHAT is this pull request doing?
Routes every text path through one info banner, with the organization as a label/value row.
Populated:
Empty, with an organization selected — same shape, so the organization is still reported:
JSON output and the stderr
notice/ truncation warnings are unchanged.How to test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add🤖 Generated with Claude Code