fix(recycling): disable key reuse when pool limit is zero - #2467
Open
huytdps13400 wants to merge 1 commit into
Open
fix(recycling): disable key reuse when pool limit is zero#2467huytdps13400 wants to merge 1 commit into
huytdps13400 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Treats a zero recycle-pool limit as a request to disable recycling before keys can be reused during the same render-stack sync. This keeps scrolled-off item instances from being reassigned while preserving the existing layout-animation recycling override and positive pool limits.
Fixes #2462
Reviewers' hat-rack 🎩
Please focus on the combined recycling-disabled predicate and the scroll-window regression in
RenderStackManager.test.ts.Screenshots or videos
Not applicable; this is an internal key-lifecycle fix covered by a focused render-stack regression test.
Test plan
yarn test --forceExit) — 14 suites, 188 testsyarn test src/__tests__/RenderStackManager.test.ts --runInBand) — 20 testsyarn type-check)yarn lint)yarn build)agent-deviceand the fixture app are unavailable in this environment