Add a service.yml file (Services DB manifest) - #4
Merged
Conversation
tobi
added a commit
that referenced
this pull request
Jul 6, 2026
Driven by analysis of /tmp/liquid-spec-results.jsonl (6.2M run lines, 8523 specs): find specs that consistently fail at low complexity without actionable guidance. Hints + complexity (#1, #2): - Add specific spec-level hints to 19 consistently-failing specs: the to_liquid-in-conditions/lookups cluster (VariableTest#test_*_calls_to_liquid_value_*, 19 specs at c=220, ~89% fail), the nil-comparison quirk (StatementsTest#test_zero_lq_or_equal_one_involving_nil, c=140, 89% fail), and the nested {% liquid %} spec (LiquidTagTest#test_nested_liquid_tag, c=130, 50% fail). - Raise ForTagTest#test_iterate_with_each_when_no_limit from c=70 to c=200: it uses instantiate:LoaderDrop (drop iteration) and was misplaced in the near-beginner band. Spec-quality gate (#3): - New test_specs_through_220_have_spec_level_hints: requires a spec-LEVEL hint (spec.hint, not suite/file effective_hint) for c<=220, with a frozen per-spec baseline (test/spec_hint_baseline.txt). Bidirectional: fails on new no-hint specs (regressions) AND stale baseline entries (hints added or specs removed), so the grandfather list shrinks instead of accreting dead weight. Threshold stays at 220 per the stated policy; generated/bulk specs are exempted exactly, not by file. - scripts/generate_spec_hint_baseline.rb regenerates the baseline. Filter-matrix hints (#4): - docs/filter_matrix_quirks.md: category-level guide for the 716 c=160 generated filter specs (date rendering, float formatting, type coercion, nil/empty, drops). - tasks/helpers.rb#format_and_write_specs accepts metadata: and writes the _metadata wrapper, so rake generate:standard_filters preserves the file-level hint instead of erasing it. standard_filters.yml metadata hint now references the doc and lists the five failure categories. Runner output (user request): - Default plain-mode output is now a single summary line then the lowest-complexity failures: "Complexity bar cleared: NN, NNNN passes, NNN failures. Next best specs to work on:" + N failure rows (default 5, --max-failures). Each failure row shows [c=N] complexity. Preamble, per-suite progress, and skipped-suite output are verbose-only (-v); --json is unchanged. --add-specs output also gated to verbose. - Updated test/runner_diagnostics_test.rb: new test_plain_output_starts_with_... asserts stdout starts with the summary and omits preamble; prioritized test asserts no "Prioritized Specs" before the header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owners: @Shopify/storefront-foundations
Service: liquid-spec
Welcome to Services DB
This PR adds a Services DB manifest (
service.yml) to your project.A service has been created on Services DB and this manifest will let you declare additional
information about your service.
Links to get you started
service.yml) documentation: https://service-docs.docs.shopify.io/getting_started/configuring_a_serviceNote:
Changes to the manifest will immediately appear on Services DB.
However, checks and metrics are run periodically and will be updated overnight.