Closed
Conversation
… so it can be popped later.
Contributor
|
Closing this because of #171 |
eq19
pushed a commit
to VirtualNetworks/liquid
that referenced
this pull request
May 2, 2025
…which are not allowed. This addresses issue Shopify#40 and merges the relevant changes by @mferretti in PR Shopify#49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added separate regular expressions for capturing
-%}and-}}followed by an optional newline character.The markup capture in
block.rbneeded to be changed from greedy(.*)?to lazy(.*?)?.Furthermore I've changed the
pushmethod to push the context before raisingStackLevelErrorso it can be popped later.IncludeTagTestfails otherwise, at least on my system.