Add ERB-like trim mode to tag syntax#171
Closed
ragalie wants to merge 1 commit intoShopify:masterfrom
Closed
Conversation
Contributor
|
i think that performance is a big issue for Shopify. if you find a performance neutral solution to this, there will be bigger changes for this to get merged. |
Closed
Contributor
|
See #215. |
This was referenced Jun 27, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebased and updated version of #49. It solves #162.
It performs slightly worse on the benchmark, but not much worse. I think this is important functionality if liquid is going to be useful for email templates, so I'm hopeful that you'll find the slight performance impact to be muted by the value of the functionality for that purpose.
Before:
After: