Skip to content

Add ERB-like trim mode to tag syntax#171

Closed
ragalie wants to merge 1 commit intoShopify:masterfrom
ragalie:trim
Closed

Add ERB-like trim mode to tag syntax#171
ragalie wants to merge 1 commit intoShopify:masterfrom
ragalie:trim

Conversation

@ragalie
Copy link
Copy Markdown

@ragalie ragalie commented Jan 25, 2013

This is a rebased and updated version of #49. It solves #162.

It performs slightly worse on the benchmark, but not much worse. I think this is important functionality if liquid is going to be useful for email templates, so I'm hopeful that you'll find the slight performance impact to be muted by the value of the functionality for that purpose.

Before:

                   user     system      total        real
parse:         4.150000   0.000000   4.150000 (  4.160474)
parse & run:   8.790000   0.020000   8.810000 (  8.830523)

After:

                   user     system      total        real
parse:         4.570000   0.000000   4.570000 (  4.574668)
parse & run:   9.140000   0.010000   9.150000 (  9.161449)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: newline

@phoet
Copy link
Copy Markdown
Contributor

phoet commented Jun 4, 2013

i think that performance is a big issue for Shopify. if you find a performance neutral solution to this, there will be bigger changes for this to get merged.

@fw42 fw42 mentioned this pull request Jun 26, 2013
@fw42
Copy link
Copy Markdown
Contributor

fw42 commented Jul 3, 2013

See #215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants