Add support for whitespace control character allowing for ERB like trim#746
Closed
evulse wants to merge 10 commits intoShopify:masterfrom
evulse:whitespace-clean
Closed
Add support for whitespace control character allowing for ERB like trim#746evulse wants to merge 10 commits intoShopify:masterfrom evulse:whitespace-clean
evulse wants to merge 10 commits intoShopify:masterfrom
evulse:whitespace-clean
Conversation
…ce trim Performance optimisation to remove regex search to detect whitespace control and instead use character index.
Contributor
Author
|
Current performance from this feature Master branch |
Contributor
Author
|
@dylanahsmith @fw42 What is the best way to have an open pull request on the liquid-c repo so that this can use to fully build and pass tests? |
Bring inline with upstream
Contributor
Author
|
This adds support for {{- and {%- syntax which will lstrip! and -}} and -%} which will rstrip! |
Contributor
Author
|
Depends on Shopify/liquid-c#30 to pass all tests. |
Contributor
|
@Shopify/liquid, need some eyes on this (and Shopify/liquid-c#30) |
Contributor
|
would you mind rebasing and squashing your commits? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #743. To solve issues #215 and #216