Add time running to _running.html.erb#452
Merged
Andy-H-Nguyen merged 1 commit intomainfrom Jul 19, 2021
Merged
Conversation
Andy-H-Nguyen
force-pushed
the
time_spent_running
branch
2 times, most recently
from
1fecdc9 to
640c5a7
Compare
Andy-H-Nguyen
force-pushed
the
time_spent_running
branch
from
640c5a7 to
21a9c3a
Compare
gmcgibbon
approved these changes
Jul 19, 2021
Member
gmcgibbon
left a comment
gmcgibbon
left a comment
There was a problem hiding this comment.
I am looking into the proper way to test this? Atm this is currently untested in the gem.
You would typically assert the content of the partial in an integration test. We don't appear to have any of those. You could technically assert in a system test, but I don't think it is worth it. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Shows the run time for tasks while it is running. (Because almost everywhere else (paused, errored) show time elapsed, except for running strangely enough.
Closes #446
Questions
I am looking into the proper way to test this? Atm this is currently untested in the gem.