Remove unused attribute from NodeProcessorFactory#438
Merged
Conversation
Previously `context_provider` was passed to `ReferenceExtractor` but it was removed at 35773e2.
Contributor
Author
|
I have signed the CLA! |
Contributor
Author
|
By the way, the CLA page seems broken. https://cla.shopify.com/individual-cla |
Member
|
👋 Hi @ryym, I just double checked, and the CLA site seems to be working now. However, it may have been broken when you signed. Sorry about that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
context_providerattribute ofNodeProcessorFactoryseems to be unused so I want to delete it.What approach did you choose and why?
I just deleted it. Both typecheck and test passed.
That attribute was initially added by #63. At that time,
ReferenceExtractorrequirescontext_provider. But in #169,context_providerwas removed from the argument ofReferenceExtractor.new.What should reviewers focus on?
If
context_provideris used in some way or will be used in the future, please close this PR.Type of Change
Checklist