[DataTable] Fix sticky header example in documentation #11405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnguyen1312
force-pushed
the
fix-sticky-header-example-from-data-table
branch
from
8b884f5 to
f372077
Compare
sam-b-rose
approved these changes
Jan 31, 2024
Member
sam-b-rose
left a comment
sam-b-rose
left a comment
There was a problem hiding this comment.
Thank you for fixing this example!
Can you recreate the changeset to be a patch update to the polaris.shopify.com package?
willnguyen1312
force-pushed
the
fix-sticky-header-example-from-data-table
branch
from
f372077 to
206cc53
Compare
Member
Author
|
Sure thing! Thanks for reviewing this, Sam 🙂 |
willnguyen1312
force-pushed
the
fix-sticky-header-example-from-data-table
branch
from
206cc53 to
2c51552
Compare
willnguyen1312
force-pushed
the
fix-sticky-header-example-from-data-table
branch
from
2c51552 to
85afba9
Compare
alex-page
approved these changes
Jan 31, 2024
Merged
mateus
pushed a commit
that referenced
this pull request
Feb 5, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/stylelint-polaris@15.2.0 ### Minor Changes - [#11551](#11551) [`ffd231e28`](ffd231e) Thanks [@mateus](https://github.com/mateus)! - Allow polaris/media-query-allowed-list lint rule to be disabled ## @shopify/polaris-migrator@0.27.2 ### Patch Changes - Updated dependencies \[[`ffd231e28`](ffd231e)]: - @shopify/stylelint-polaris@15.2.0 ## polaris.shopify.com@0.62.5 ### Patch Changes - [#11405](#11405) [`a8fd0dec9`](a8fd0de) Thanks [@willnguyen1312](https://github.com/willnguyen1312)! - Fixed sticky header example in docs Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The current example in documentation is broken in production
WHAT is this pull request doing?
Since we used empty array as initial value for
sortedRowsstate which is truthy by default. We should stick withnullto correct it and be consistent with other examples 😉How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes