Allow polaris/media-query-allowed-list rule to be disabled #11551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/snapit |
mateus
force-pushed
the
lint-allow-disable
branch
2 times, most recently
from
5fc3d6e to
5dc5907
Compare
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @mateus! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20240204224556yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20240204224556 |
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @mateus! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20240204232315yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20240204232315 |
mateus
force-pushed
the
lint-allow-disable
branch
from
7c60fce to
5dc5907
Compare
mateus
changed the title
mateus
force-pushed
the
lint-allow-disable
branch
2 times, most recently
from
395f73e to
9b2d614
Compare
mateus
force-pushed
the
lint-allow-disable
branch
from
9b2d614 to
3c97934
Compare
aaronccasanova
approved these changes
Feb 5, 2024
alex-page
approved these changes
Feb 5, 2024
Merged
mateus
pushed a commit
that referenced
this pull request
Feb 5, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/stylelint-polaris@15.2.0 ### Minor Changes - [#11551](#11551) [`ffd231e28`](ffd231e) Thanks [@mateus](https://github.com/mateus)! - Allow polaris/media-query-allowed-list lint rule to be disabled ## @shopify/polaris-migrator@0.27.2 ### Patch Changes - Updated dependencies \[[`ffd231e28`](ffd231e)]: - @shopify/stylelint-polaris@15.2.0 ## polaris.shopify.com@0.62.5 ### Patch Changes - [#11405](#11405) [`a8fd0dec9`](a8fd0de) Thanks [@willnguyen1312](https://github.com/willnguyen1312)! - Fixed sticky header example in docs Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…1551) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Open it as a draft if it’s a work in progress --> ### WHY are these changes introduced? Currently, it's not possible to disable the `polaris/media-query-allowed-list` rule from `polaris/coverage`. <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? This PR adds a new option called `disabled` to allow the rule to be disabled. <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. Include a video if your changes include interactive content. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> ### How to 🎩 Configuration being tested and implemented on Shopify/web#117384 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Currently, it's not possible to disable the
polaris/media-query-allowed-listrule frompolaris/coverage.WHAT is this pull request doing?
This PR adds a new option called
disabledto allow the rule to be disabled.How to 🎩
Configuration being tested and implemented on https://github.com/Shopify/web/pull/117384
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes