[ProgressBar] Add color prop #3415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
approved these changes
Oct 7, 2020
kaelig
commented
Oct 7, 2020
Comment on lines
43
to
46
| .colorHighlight { | ||
| --p-progressbar-background: var(--p-surface-neutral, #{color('sky')}); | ||
| --p-progressbar-indicator: var(--p-border-highlight, #{color('teal')}); | ||
| } |
There was a problem hiding this comment.
Not sure component-specific custom properties are the right way to fix this, guidance would be appreciated.
|
🟢 This pull request modifies 4 files and might impact 1 other files. Details:All files potentially affected (total: 1)📄
|
|
Note: This isn't urgent, and will require a chat with designers to agree on whether this should make it into Polaris and if the colors chosen are appropriate. |
kyledurand
approved these changes
Oct 15, 2020
alex-page
force-pushed
the
master
branch
2 times, most recently
from
4eab9e5 to
9e09ba7
Compare
|
This last merge makes this change compatible with the default new design language! I'll ship it soon. |
|
FYI @whizkydee, it'd be great if you could make time to update the OnboardingTaskCard component over the next few weeks. |
size-limit report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This will fix an issue where a home card uses imperative language to describe the color prop's possible values in this polaris-next fork of ProgressBar in web.
This forked ProgressBar is used in two Home Cards, one of them being:
I couldn't reproduce the other one, but the code shows it uses a "green" color:
https://github.com/Shopify/web/blob/master/app/sections/Home/HomeIndex/components/Onboarding/components/OnboardingFooter/components/OnboardingProgressBar/OnboardingProgressBar.tsx#L32
WHAT is this pull request doing?
Adds a new prop using the new color system, that will help us remove this fork from polaris-next.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Check out the new ProgressBar example in Storybook.
🎩 checklist
README.mdwith documentation changes