-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update to node 12.22.0 and react-testing v3.2.0 #4349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Released on 2021-03-30, this is the first version of node where esmodules are considered stable. We're not relying on that yet, but this sets the stage for the future.
This adds support for React 17 so future migration will be easier
cff9ba4 to
3f3e19e
Compare
Contributor
size-limit report
|
chloerice
approved these changes
Jul 29, 2021
Member
chloerice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🙏🏽
thiagoloschi
approved these changes
Jul 29, 2021
voiid
added a commit
that referenced
this pull request
Aug 11, 2021
* Upgrade to node v12 (#4191) * Move to node v12 * Bump merge-deep from 3.0.2 to 3.0.3 (#4254) Bumps [merge-deep](https://github.com/jonschlinkert/merge-deep) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/jonschlinkert/merge-deep/releases) - [Commits](jonschlinkert/merge-deep@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: merge-deep dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ws in /examples/create-react-app-ts-react-testing (#4242) Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/commits) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ws from 6.2.1 to 6.2.2 in /examples/create-react-app (#4241) Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/commits) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ws from 6.2.1 to 6.2.2 in /examples/webpack (#4240) Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/commits) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update UNRELEASED.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump react and react-dom to v16.14.0 (#4279) Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> * [TextField] Make autoComplete prop a required string (#4267) * Require autoComplete prop on TextField * switch to autoComplete="off" as default * Adding off recommendation. * Fix link formatting issue in TextField/README.md Co-authored-by: Genevieve Bulger <genevieve.bulger@shopify.com> * Update browserslist to match shopify/browserslist-config v3.0.0 (#4304) - Desktop Safari version is "last 3 safari versions" - mapping to Safari 13.1 - ios Safari version is "ios >= 13.4" - mapping to ios_saf 13.4-13.7 * [AutoComplete] Rebuild autocomplete internals to use new accessible components (#3910) * Rebuild AutoComplete internals to fix accessibility issues - Replace internals with new combobox and list box - Add support for legacy combobox - Allow TextField and Checkbox to leverage new combobox - Include additional test coverage for autocomplete and new components Co-authored-by: Andrew Musgrave <andrew.musgrave@shopify.com> Co-authored-by: Daniel Leroux <daniel.leroux@shopify.com> * Fix some accessibility warnings on listbox stories * Remove listbox section example Co-authored-by: Andrew Musgrave <andrew.musgrave@shopify.com> Co-authored-by: Daniel Leroux <daniel.leroux@shopify.com> * Update to node 12.22.0 and react-testing v3.2.0 (#4349) * Update node version to 12.22.0 Released on 2021-03-30, this is the first version of node where esmodules are considered stable. We're not relying on that yet, but this sets the stage for the future. * Update @shopify/react-testing to v3.2.0 This adds support for React 17 so future migration will be easier * Remove deprecated languages (#4351) * Update translation.yml * Delete locales/hi.json * Delete locales/ms.json * format translation.yml as expected Co-authored-by: translation-platform[bot] <35075727+translation-platform@users.noreply.github.com> * Rename ComboBox and ListBox to Combobox and Listbox (#4379) * Fix autocomlete docs Co-authored-by: Alex Page <alex@alexpage.com.au> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Co-authored-by: Andrew McGoveran <andrew.mcgoveran@shopify.com> Co-authored-by: Genevieve Bulger <genevieve.bulger@shopify.com> Co-authored-by: Andrew Musgrave <andrew.musgrave@shopify.com> Co-authored-by: Daniel Leroux <daniel.leroux@shopify.com> Co-authored-by: Kyle Durand <kyle.durand@shopify.com> Co-authored-by: Al-Campuzano <32461613+Al-Campuzano@users.noreply.github.com> Co-authored-by: translation-platform[bot] <35075727+translation-platform@users.noreply.github.com>
alex-page
pushed a commit
that referenced
this pull request
Aug 25, 2021
* Update node version to 12.22.0 Released on 2021-03-30, this is the first version of node where esmodules are considered stable. We're not relying on that yet, but this sets the stage for the future. * Update @shopify/react-testing to v3.2.0 This adds support for React 17 so future migration will be easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Preparing for futures around updating to support react 17 and building/testing/linting using sewing-ki-next.
WHAT is this pull request doing?
@shopify/react-testingto v3.2.0. This adds support for React 17 so testing react 17 will be easier (along with other ongoing efforts in enzyme removal)@shopify/react-testingrequires 12.14.0, but I figured we could jump a few more versions as it will unlock being able to leverage future sewing-kit-next improvements down the line without additional changes.