Skip to content

Rename ComboBox and ListBox to Combobox and Listbox #4379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2021
Merged

Rename ComboBox and ListBox to Combobox and Listbox #4379

merged 1 commit into from
Aug 11, 2021

Conversation

@voiid
Copy link
Contributor

@voiid voiid commented Aug 10, 2021

WHY are these changes introduced?

Aligned naming with w3c standards for consistency/clarity.

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@voiid voiid force-pushed the align-listbox-combobox-naming branch from 2a91bf4 to c2df5e9 Compare August 10, 2021 23:28
@voiid voiid force-pushed the align-listbox-combobox-naming branch from c2df5e9 to af95cfb Compare August 10, 2021 23:39
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2021

size-limit report

Path Size
cjs 143.9 KB (-0.01% 🔽)
esm 97.86 KB (-0.01% 🔽)
esnext 143.53 KB (-0.01% 🔽)
css 34.53 KB (0%)

@voiid voiid marked this pull request as ready for review August 10, 2021 23:43
@voiid voiid assigned dleroux and unassigned dleroux Aug 10, 2021
@voiid voiid requested a review from dleroux August 10, 2021 23:44
@voiid voiid self-assigned this Aug 10, 2021
@voiid voiid merged commit d36b9ee into v7.0.0-release Aug 11, 2021
@voiid voiid deleted the align-listbox-combobox-naming branch August 11, 2021 14:27
voiid added a commit that referenced this pull request Aug 11, 2021
@voiid @dependabot
@BPScott @andrewmcgov @gcornhill @AndrewMusgrave @dleroux @kyledurand @Al-Campuzano @translation-platform
V7.0.0 release (#4388)
e9e9b79 
* Upgrade to node v12 (#4191)

* Move to node v12

* Bump merge-deep from 3.0.2 to 3.0.3 (#4254)

Bumps [merge-deep](https://github.com/jonschlinkert/merge-deep) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/jonschlinkert/merge-deep/releases)
- [Commits](jonschlinkert/merge-deep@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: merge-deep
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ws in /examples/create-react-app-ts-react-testing (#4242)

Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/commits)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ws from 6.2.1 to 6.2.2 in /examples/create-react-app (#4241)

Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/commits)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ws from 6.2.1 to 6.2.2 in /examples/webpack (#4240)

Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/commits)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update UNRELEASED.md

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump react and react-dom to v16.14.0 (#4279)

Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>

* [TextField] Make autoComplete prop a required string (#4267)

* Require autoComplete prop on TextField

* switch to autoComplete="off" as default

* Adding off recommendation.

* Fix link formatting issue in TextField/README.md

Co-authored-by: Genevieve Bulger <genevieve.bulger@shopify.com>

* Update browserslist to match shopify/browserslist-config v3.0.0 (#4304)

- Desktop Safari version is "last 3 safari versions" - mapping to
  Safari 13.1
- ios Safari version is "ios >= 13.4" - mapping to ios_saf 13.4-13.7

* [AutoComplete] Rebuild autocomplete internals to use new accessible components (#3910)

* Rebuild AutoComplete internals to fix accessibility issues

 - Replace internals with new combobox and list box
 - Add support for legacy combobox
 - Allow TextField and Checkbox to leverage new combobox
 - Include additional test coverage for autocomplete and new components

Co-authored-by: Andrew Musgrave <andrew.musgrave@shopify.com>
Co-authored-by: Daniel Leroux <daniel.leroux@shopify.com>

* Fix some accessibility warnings on listbox stories

* Remove listbox section example

Co-authored-by: Andrew Musgrave <andrew.musgrave@shopify.com>
Co-authored-by: Daniel Leroux <daniel.leroux@shopify.com>

* Update to node 12.22.0 and react-testing v3.2.0 (#4349)

* Update node version to 12.22.0

Released on 2021-03-30, this is the first version of node where
esmodules are considered stable. We're not relying on that yet, but this
sets the stage for the future.

* Update @shopify/react-testing to v3.2.0

This adds support for React 17 so future migration will be easier

* Remove deprecated languages (#4351)

* Update translation.yml

* Delete locales/hi.json

* Delete locales/ms.json

* format translation.yml as expected

Co-authored-by: translation-platform[bot] <35075727+translation-platform@users.noreply.github.com>

* Rename ComboBox and ListBox to Combobox and Listbox (#4379)

* Fix autocomlete docs

Co-authored-by: Alex Page <alex@alexpage.com.au>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
Co-authored-by: Andrew McGoveran <andrew.mcgoveran@shopify.com>
Co-authored-by: Genevieve Bulger <genevieve.bulger@shopify.com>
Co-authored-by: Andrew Musgrave <andrew.musgrave@shopify.com>
Co-authored-by: Daniel Leroux <daniel.leroux@shopify.com>
Co-authored-by: Kyle Durand <kyle.durand@shopify.com>
Co-authored-by: Al-Campuzano <32461613+Al-Campuzano@users.noreply.github.com>
Co-authored-by: translation-platform[bot] <35075727+translation-platform@users.noreply.github.com>
alex-page pushed a commit that referenced this pull request Aug 25, 2021
@voiid
Rename ComboBox and ListBox to Combobox and Listbox (#4379)
4e3d0aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dleroux dleroux dleroux approved these changes

Assignees

@voiid voiid

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@voiid @dleroux