Skip to content

Conversation

laranoell
Copy link
Contributor

@laranoell laranoell commented Jan 14, 2019

Resolves issue:
Modal Title - Vertical alignment #868

Actual behavior

image

Proposed Change:

Bump margin-top up to 0.4rem (from 0.2rem)
image

WHAT is this pull request doing?

Slight change to margin top, modal header component

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import * as React from 'react';
import {Page} from '@shopify/polaris';

interface State {}

export default class Playground extends React.Component<never, State> {
  render() {
    return (
      <Page title="Playground">
        {/* Add the code you want to test here */}
      </Page>
    );
  }
}

🎩 checklist

@ghost
Copy link

ghost commented Jan 14, 2019

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack.

@BPScott BPScott temporarily deployed to polaris-react-pr-870 January 14, 2019 22:43 Inactive
@dpersing dpersing self-requested a review January 23, 2019 17:07
@dpersing
Copy link

Hi @laranoell! Thanks for this, it looks great. Could you add an entry to UNRELEASED.md?


### Bug fixes

- Fixed vertical misalignment in `Banner.Header`([#870](https://github.com/Shopify/polaris-react/pull/870))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ @dpersing added! Let me know if I should update the format (first time contributing to Polaris)

Copy link

@dpersing dpersing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Go ahead and merge! And welcome. 😄

@laranoell laranoell merged commit 6a6e781 into master Jan 24, 2019
@ghost
Copy link

ghost commented Jan 24, 2019

🎉 Thanks for your contribution to Polaris React!

@BPScott BPScott temporarily deployed to production January 28, 2019 16:33 Inactive
@kaelig kaelig deleted the ModalTitleStyleChange branch April 26, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants