<Box> Replace border shorthand with individual values for color, width and style #8910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changeset
Contributor
size-limit report 📦
|
alex-page
requested review from
aaronccasanova,
kyledurand,
laurkim and
lgriffee
and removed request for
aaronccasanova
kyledurand
reviewed
Apr 11, 2023
Member
kyledurand
left a comment
kyledurand
left a comment
There was a problem hiding this comment.
I like the idea! Looks like some things could use some cleaning up but otherwise I'm onboard.
lgriffee
reviewed
Apr 11, 2023
lgriffee
reviewed
Apr 11, 2023
lgriffee
reviewed
Apr 11, 2023
lgriffee
reviewed
Apr 11, 2023
lgriffee
reviewed
Apr 11, 2023
lgriffee
reviewed
Apr 11, 2023
lgriffee
reviewed
Apr 11, 2023
lgriffee
reviewed
Apr 11, 2023
lgriffee
reviewed
Apr 11, 2023
lgriffee
reviewed
Apr 11, 2023
polaris.shopify.com/pages/examples/bleed-specific-direction.tsx
Outdated
Show resolved
Hide resolved
lgriffee
reviewed
Apr 11, 2023
polaris.shopify.com/pages/examples/bleed-specific-direction.tsx
Outdated
Show resolved
Hide resolved
alex-page
commented
Apr 13, 2023
| overflowY="hidden" | ||
| background="bg" | ||
| borderRadius="2" | ||
| outline="transparent" |
Member
Author
There was a problem hiding this comment.
Unsure what the purpose of this is here. Removing it.
Member
Author
|
@aaronccasanova @lgriffee @laurkim @kyledurand can I get one more thorough review here. If it looks good lets get this into |
kyledurand
reviewed
Apr 13, 2023
Member
There was a problem hiding this comment.
Still some pretty funky stuff going on with borders here. Looks like we've lost the radius in some cases and they're getting doubled up as well.
build | main
Edit
I pushed up a change for setting default widths from initial to 0.
Seems to have fixed a bunch of chromatic issues 660c1aa
laurkim
reviewed
Apr 13, 2023
laurkim
reviewed
Apr 13, 2023
laurkim
reviewed
Apr 13, 2023
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
kyledurand
approved these changes
Apr 17, 2023
laurkim
approved these changes
Apr 17, 2023
chloerice
requested changes
Apr 17, 2023
Member
chloerice
left a comment
chloerice
left a comment
There was a problem hiding this comment.
Changes look great! We just need migrations for this to ship.
Merged
alex-page
added a commit
that referenced
this pull request
Apr 17, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.45.0 ### Minor Changes - [#8910](#8910) [`91a9b77e6`](91a9b77) Thanks [@alex-page](https://github.com/alex-page)! - <Box> Replaced outline, border, borderBlockEnd, borderBlockStart, borderInlineEnd, borderInlineStart properties with access to borderColor, borderWidth, outlineColor and outlineWidth ### Patch Changes - [#8990](#8990) [`9674cc906`](9674cc9) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update tokens for border of `Tabs` on hover and pressed state to create better quality interaction. ## @shopify/polaris-cli@0.1.29 ## @shopify/polaris-icons@6.13.0 ### Minor Changes - [#8924](#8924) [`4880e3ed7`](4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon * [#8861](#8861) [`2bc90503d`](2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor - [#8919](#8919) [`7349d4108`](7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ## polaris.shopify.com@0.49.1 ### Patch Changes - Updated dependencies \[[`9674cc906`](9674cc9), [`91a9b77e6`](91a9b77)]: - @shopify/polaris@10.45.0 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Alex Page <hi@alexpage.dev>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
…h and style (Shopify#8910) ### WHY are these changes introduced? Gives users access to our color tokens, width tokens and the option to have different border styles. ### WHAT is this pull request doing? - [x] Replaces all the shorthand border usage in Box with access to borderColor, borderWidth and borderStyle - [x] Does the same thing for outline - [x] Replaces `outline` `border` `borderBlockEnd` `borderInlineStart` `borderInlineEnd` `borderBlockStart` with `outlineColor`, `outlineStyle`, `borderColor` and `borderStyle` - [x] Defaults the `borderStyle` to `solid` when a `border/outlineColor` or `border/outlineWidth` prop is used - [x] Updates usage `Box` components that used these values **⚠️ Important note** This is a breaking change for the Alpha Box component --------- Co-authored-by: Laura Griffee <laura@mailzone.com> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.45.0 ### Minor Changes - [Shopify#8910](Shopify#8910) [`91a9b77e6`](Shopify@91a9b77) Thanks [@alex-page](https://github.com/alex-page)! - <Box> Replaced outline, border, borderBlockEnd, borderBlockStart, borderInlineEnd, borderInlineStart properties with access to borderColor, borderWidth, outlineColor and outlineWidth ### Patch Changes - [Shopify#8990](Shopify#8990) [`9674cc906`](Shopify@9674cc9) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update tokens for border of `Tabs` on hover and pressed state to create better quality interaction. ## @shopify/polaris-cli@0.1.29 ## @shopify/polaris-icons@6.13.0 ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon * [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ## polaris.shopify.com@0.49.1 ### Patch Changes - Updated dependencies \[[`9674cc906`](Shopify@9674cc9), [`91a9b77e6`](Shopify@91a9b77)]: - @shopify/polaris@10.45.0 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Alex Page <hi@alexpage.dev>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…h and style (Shopify#8910) ### WHY are these changes introduced? Gives users access to our color tokens, width tokens and the option to have different border styles. ### WHAT is this pull request doing? - [x] Replaces all the shorthand border usage in Box with access to borderColor, borderWidth and borderStyle - [x] Does the same thing for outline - [x] Replaces `outline` `border` `borderBlockEnd` `borderInlineStart` `borderInlineEnd` `borderBlockStart` with `outlineColor`, `outlineStyle`, `borderColor` and `borderStyle` - [x] Defaults the `borderStyle` to `solid` when a `border/outlineColor` or `border/outlineWidth` prop is used - [x] Updates usage `Box` components that used these values **⚠️ Important note** This is a breaking change for the Alpha Box component --------- Co-authored-by: Laura Griffee <laura@mailzone.com> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.45.0 ### Minor Changes - [Shopify#8910](Shopify#8910) [`91a9b77e6`](Shopify@9e5876e) Thanks [@alex-page](https://github.com/alex-page)! - <Box> Replaced outline, border, borderBlockEnd, borderBlockStart, borderInlineEnd, borderInlineStart properties with access to borderColor, borderWidth, outlineColor and outlineWidth ### Patch Changes - [Shopify#8990](Shopify#8990) [`9674cc906`](Shopify@807c9d8) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update tokens for border of `Tabs` on hover and pressed state to create better quality interaction. ## @shopify/polaris-cli@0.1.29 ## @shopify/polaris-icons@6.13.0 ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@1ad1a62) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon * [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@3dc9640) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@e29f62e) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ## polaris.shopify.com@0.49.1 ### Patch Changes - Updated dependencies \[[`9674cc906`](Shopify@807c9d8), [`91a9b77e6`](Shopify@9e5876e)]: - @shopify/polaris@10.45.0 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Alex Page <hi@alexpage.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Gives users access to our color tokens, width tokens and the option to have different border styles.
WHAT is this pull request doing?
outlineborderborderBlockEndborderInlineStartborderInlineEndborderBlockStartwithoutlineColor,outlineStyle,borderColorandborderStyleborderStyletosolidwhen aborder/outlineColororborder/outlineWidthprop is usedBoxcomponents that used these values