Skip to content

Add explore images icon #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2023
Merged

Add explore images icon #8861

merged 2 commits into from
Apr 12, 2023
+17 −0

Conversation

@AlejandroE
Copy link
Contributor

@AlejandroE AlejandroE commented Apr 5, 2023 •
edited
Loading

WHY are these changes introduced?

closes: #8862

Adds a new icon to represent the menu action opening free (burst) images in OSE

New-Icon

🎩 checklist

@AlejandroE
Copy link
Contributor Author

AlejandroE commented Apr 5, 2023

CC @osamaghazal01

@osamaghazal01 osamaghazal01 mentioned this pull request Apr 5, 2023
Closed
@osamaghazal01
Copy link

osamaghazal01 commented Apr 5, 2023

Solves this issue
#8862

@AlejandroE AlejandroE requested a review from a team April 5, 2023 15:20
@AlejandroE AlejandroE force-pushed the add-explore-images-icon branch from 4f84b1a to 391f1f0 Compare April 5, 2023 15:27
martenbjork
martenbjork suggested changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@martenbjork martenbjork left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

The icon description in the yml shouldn't be a Markdown table. It should just be a simple string. (I saw that AddImageMajor icon had a commented out Markdown table, but that's incorrect — sorry about the confusion!)

@AlejandroE AlejandroE force-pushed the add-explore-images-icon branch from 391f1f0 to 8f03049 Compare April 5, 2023 15:30
@AlejandroE AlejandroE force-pushed the add-explore-images-icon branch from 8f03049 to def6bc0 Compare April 5, 2023 15:32
@heyjoethomas
Copy link
Contributor

heyjoethomas commented Apr 5, 2023

Please make sure to add this into the Figma UIKit as well. If you need help or have questions on how to do that feel free to reach out.

@AlejandroE
Copy link
Contributor Author

AlejandroE commented Apr 5, 2023

@heyjoethomas thanks for the heads up! I'm approaching the end of my day but will figure that out tomorrow :D

@osamaghazal01
Copy link

osamaghazal01 commented Apr 5, 2023

@heyjoethomas I have access to this kit but I don't have access to edit.

@heyjoethomas
Copy link
Contributor

heyjoethomas commented Apr 5, 2023

@heyjoethomas I have access to this kit but I don't have access to edit.

You can create a branch to add the icon. Then just request a review when ready and I can merge and publish.

kyledurand
kyledurand requested changes Apr 5, 2023
View reviewed changes
Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to change from major to minor release

.changeset/poor-walls-care.md Outdated
'@shopify/polaris-icons': major
---

Adds a new icon used to represent exploring a variety of imagery assets
Copy link
Member

@kyledurand kyledurand Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Adds a new icon used to represent exploring a variety of imagery assets
Added ExploreImagesMajor icon

.changeset/poor-walls-care.md Outdated
@@ -0,0 +1,5 @@
---
'@shopify/polaris-icons': major
Copy link
Member

@kyledurand kyledurand Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@shopify/polaris-icons': major
'@shopify/polaris-icons': minor

@AlejandroE AlejandroE force-pushed the add-explore-images-icon branch 2 times, most recently from 9a3ca1a to 46d8590 Compare April 6, 2023 16:49
@AlejandroE
Copy link
Contributor Author

AlejandroE commented Apr 6, 2023

@kyledurand thanks Kyle! made the changes but the checks seem to be flaky, might be github.

kyledurand
kyledurand approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I pushed up some changes removing extraneous attributes that were causing tests to fail. There may be a chance we'll need to skip the comment check if that still fails. Seems like a false positive.

Last thing I'm seeing is that the icon isn't centered in its canvas. I'm assuming that's intentional but wanted to flag it just in case

image

@kyledurand kyledurand added the 🤖Skip Comment Check Skip the migrator comment CI check label Apr 6, 2023
@sam-b-rose sam-b-rose force-pushed the add-explore-images-icon branch from 8050774 to 351a384 Compare April 6, 2023 18:53
@osamaghazal01
Copy link

osamaghazal01 commented Apr 10, 2023

Thank you folks :)

@AlejandroE AlejandroE merged commit 2bc9050 into main Apr 12, 2023
@AlejandroE AlejandroE deleted the add-explore-images-icon branch April 12, 2023 15:05
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Apr 12, 2023
Merged
chloerice pushed a commit that referenced this pull request Apr 17, 2023
@shopify-github-actions-access @github-actions
Version Packages (#8929)
5a04ca1 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@7.0.0

### Major Changes

- [#8919](#8919)
[`7349d4108`](7349d41)
Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard
major + minor icons

### Minor Changes

- [#8924](#8924)
[`4880e3ed7`](4880e3e)
Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor
icon


- [#8861](#8861)
[`2bc90503d`](2bc9050)
Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added
ExploreImagesMajor

## @shopify/stylelint-polaris@10.0.0

### Major Changes

- [#8973](#8973)
[`f1a3ad756`](f1a3ad7)
Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the
`custom-property-disallowed-list` rule and added deprecated v10 custom
properties.


- [#8455](#8455)
[`80eb3ac55`](80eb3ac)
Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8
custom properties, functions, mixins, and mixin maps from
stylelint-polaris

### Minor Changes

- [#8968](#8968)
[`dbe68efb4`](dbe68ef)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added
`custom-property-disallowed-list` rule

## @shopify/polaris@10.44.0

### Minor Changes

- [#8936](#8936)
[`a2c9b1d24`](a2c9b1d)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to
HorizontalStack


- [#8773](#8773)
[`e8c5a2243`](e8c5a22)
Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an
optional `onSpinnerChange` prop to`TextField`
    -   Added an optional `largeStep` prop to `TextField`
- Added `TextField` `Spinner` keypress interactions for Home, End, Page
Up, Page Down


- [#8876](#8876)
[`090d09683`](090d096)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters`
to support hiding both filters and search field


- [#8973](#8973)
[`f1a3ad756`](f1a3ad7)
Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the
`custom-property-disallowed-list` rule and added deprecated v10 custom
properties.


- [#8937](#8937)
[`fcc543928`](fcc5439)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns`
to `HorizontalGrid`


- [#8938](#8938)
[`289dce569`](289dce5)
Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation
from `Grid` component


- [#8935](#8935)
[`7f3053342`](7f30533)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed
`AlphaStack` to `VerticalStack`


- [#8596](#8596)
[`421bb49dc`](421bb49)
Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix
minimum height overflowing in iOS Webkit browsers


- [#8953](#8953)
[`500eed660`](500eed6)
Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added
`customActivator` prop to `TopBar.UserMenu`
- Added support for setting a `ReactNode` on `ActionList` `Section`
`title`

### Patch Changes

- [#8842](#8842)
[`bd64fa583`](bd64fa5)
Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the
Exiting animation state from Popovers, causing them to close immediately
instead of after a 100ms delay.


- [#8913](#8913)
[`261355f07`](261355f)
Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical
alignment of elements within the `AlphaFilters` component


- [#8954](#8954)
[`f9366c22d`](f9366c2)
Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property
names to align with new component names for `HorizontalGrid`,
`HorizontalStack`, and `VerticalStack`


- [#8912](#8912)
[`1cc47495a`](1cc4749)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions`
to include wrapping tooltip on Popover activator

- Updated dependencies
\[[`4880e3ed7`](4880e3e),
[`7349d4108`](7349d41),
[`2bc90503d`](2bc9050)]:
    -   @shopify/polaris-icons@7.0.0

## @shopify/polaris-cli@0.1.28

### Patch Changes

-   Updated dependencies \[]:
    -   @shopify/polaris-migrator@0.17.2

## @shopify/polaris-codemods@0.0.3

### Patch Changes

- Updated dependencies
\[[`f1a3ad756`](f1a3ad7),
[`80eb3ac55`](80eb3ac),
[`dbe68efb4`](dbe68ef)]:
    -   @shopify/stylelint-polaris@10.0.0

## @shopify/polaris-migrator@0.17.2

### Patch Changes

- Updated dependencies
\[[`f1a3ad756`](f1a3ad7),
[`80eb3ac55`](80eb3ac),
[`dbe68efb4`](dbe68ef)]:
    -   @shopify/stylelint-polaris@10.0.0

## polaris.shopify.com@0.49.0

### Minor Changes

- [#8876](#8876)
[`090d09683`](090d096)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters`
to support hiding both filters and search field


- [#8973](#8973)
[`f1a3ad756`](f1a3ad7)
Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the
`custom-property-disallowed-list` rule and added deprecated v10 custom
properties.


- [#8967](#8967)
[`45d978e7b`](45d978e)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version
matchup table to `stylelint-polaris` documentation


- [#8986](#8986)
[`f70f586ee`](f70f586)
Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for
the `react-rename-component` codemod


- [#8935](#8935)
[`7f3053342`](7f30533)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed
`AlphaStack` to `VerticalStack`


- [#8920](#8920)
[`2bad4e305`](2bad4e3)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button
to markdown headings with ids

### Patch Changes

- [#8915](#8915)
[`c8a130caf`](c8a130c)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added
scroll-margin-top to anchor links to prevent top bar overlay


- [#8455](#8455)
[`80eb3ac55`](80eb3ac)
Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8
custom properties, functions, mixins, and mixin maps from
stylelint-polaris

- Updated dependencies
\[[`a2c9b1d24`](a2c9b1d),
[`e8c5a2243`](e8c5a22),
[`090d09683`](090d096),
[`bd64fa583`](bd64fa5),
[`f1a3ad756`](f1a3ad7),
[`261355f07`](261355f),
[`fcc543928`](fcc5439),
[`4880e3ed7`](4880e3e),
[`7349d4108`](7349d41),
[`2bc90503d`](2bc9050),
[`f9366c22d`](f9366c2),
[`289dce569`](289dce5),
[`7f3053342`](7f30533),
[`421bb49dc`](421bb49),
[`500eed660`](500eed6),
[`1cc47495a`](1cc4749)]:
    -   @shopify/polaris@10.44.0
    -   @shopify/polaris-icons@7.0.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@alex-page alex-page mentioned this pull request Apr 17, 2023
Merged
alex-page added a commit that referenced this pull request Apr 17, 2023
@shopify-github-actions-access @github-actions @alex-page
Version Packages (#8993)
17e2f13 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@10.45.0

### Minor Changes

- [#8910](#8910)
[`91a9b77e6`](91a9b77)
Thanks [@alex-page](https://github.com/alex-page)! - <Box> Replaced
outline, border, borderBlockEnd, borderBlockStart, borderInlineEnd,
borderInlineStart properties with access to borderColor, borderWidth,
outlineColor and outlineWidth

### Patch Changes

- [#8990](#8990)
[`9674cc906`](9674cc9)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update tokens
for border of `Tabs` on hover and pressed state to create better quality
interaction.

## @shopify/polaris-cli@0.1.29


## @shopify/polaris-icons@6.13.0

### Minor Changes

- [#8924](#8924)
[`4880e3ed7`](4880e3e)
Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor
icon

* [#8861](#8861)
[`2bc90503d`](2bc9050)
Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added
ExploreImagesMajor

- [#8919](#8919)
[`7349d4108`](7349d41)
Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard
major + minor icons



## polaris.shopify.com@0.49.1

### Patch Changes

- Updated dependencies
\[[`9674cc906`](9674cc9),
[`91a9b77e6`](91a9b77)]:
    -   @shopify/polaris@10.45.0

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alex Page <hi@alexpage.dev>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@AlejandroE @kyledurand @juzser
Add explore images icon (Shopify#8861)
8b39607 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

closes: Shopify#8862

Adds a new icon to represent the menu action opening free (burst) images
in OSE

<img width="244" alt="New-Icon"
src="https://user-images.githubusercontent.com/103959854/229194990-c575b1de-fdb6-4d3e-bcf0-9e5f8d3a5739.png">

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [x] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [x] Updated the component's `README.md` with documentation changes
- [x] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@shopify-github-actions-access @github-actions @juzser
Version Packages (Shopify#8929)
8b84ba9 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@7.0.0

### Major Changes

- [Shopify#8919](Shopify#8919)
[`7349d4108`](Shopify@7349d41)
Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard
major + minor icons

### Minor Changes

- [Shopify#8924](Shopify#8924)
[`4880e3ed7`](Shopify@4880e3e)
Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor
icon


- [Shopify#8861](Shopify#8861)
[`2bc90503d`](Shopify@2bc9050)
Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added
ExploreImagesMajor

## @shopify/stylelint-polaris@10.0.0

### Major Changes

- [Shopify#8973](Shopify#8973)
[`f1a3ad756`](Shopify@f1a3ad7)
Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the
`custom-property-disallowed-list` rule and added deprecated v10 custom
properties.


- [Shopify#8455](Shopify#8455)
[`80eb3ac55`](Shopify@80eb3ac)
Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8
custom properties, functions, mixins, and mixin maps from
stylelint-polaris

### Minor Changes

- [Shopify#8968](Shopify#8968)
[`dbe68efb4`](Shopify@dbe68ef)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added
`custom-property-disallowed-list` rule

## @shopify/polaris@10.44.0

### Minor Changes

- [Shopify#8936](Shopify#8936)
[`a2c9b1d24`](Shopify@a2c9b1d)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to
HorizontalStack


- [Shopify#8773](Shopify#8773)
[`e8c5a2243`](Shopify@e8c5a22)
Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an
optional `onSpinnerChange` prop to`TextField`
    -   Added an optional `largeStep` prop to `TextField`
- Added `TextField` `Spinner` keypress interactions for Home, End, Page
Up, Page Down


- [Shopify#8876](Shopify#8876)
[`090d09683`](Shopify@090d096)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters`
to support hiding both filters and search field


- [Shopify#8973](Shopify#8973)
[`f1a3ad756`](Shopify@f1a3ad7)
Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the
`custom-property-disallowed-list` rule and added deprecated v10 custom
properties.


- [Shopify#8937](Shopify#8937)
[`fcc543928`](Shopify@fcc5439)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns`
to `HorizontalGrid`


- [Shopify#8938](Shopify#8938)
[`289dce569`](Shopify@289dce5)
Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation
from `Grid` component


- [Shopify#8935](Shopify#8935)
[`7f3053342`](Shopify@7f30533)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed
`AlphaStack` to `VerticalStack`


- [Shopify#8596](Shopify#8596)
[`421bb49dc`](Shopify@421bb49)
Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix
minimum height overflowing in iOS Webkit browsers


- [Shopify#8953](Shopify#8953)
[`500eed660`](Shopify@500eed6)
Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added
`customActivator` prop to `TopBar.UserMenu`
- Added support for setting a `ReactNode` on `ActionList` `Section`
`title`

### Patch Changes

- [Shopify#8842](Shopify#8842)
[`bd64fa583`](Shopify@bd64fa5)
Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the
Exiting animation state from Popovers, causing them to close immediately
instead of after a 100ms delay.


- [Shopify#8913](Shopify#8913)
[`261355f07`](Shopify@261355f)
Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical
alignment of elements within the `AlphaFilters` component


- [Shopify#8954](Shopify#8954)
[`f9366c22d`](Shopify@f9366c2)
Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property
names to align with new component names for `HorizontalGrid`,
`HorizontalStack`, and `VerticalStack`


- [Shopify#8912](Shopify#8912)
[`1cc47495a`](Shopify@1cc4749)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions`
to include wrapping tooltip on Popover activator

- Updated dependencies
\[[`4880e3ed7`](Shopify@4880e3e),
[`7349d4108`](Shopify@7349d41),
[`2bc90503d`](Shopify@2bc9050)]:
    -   @shopify/polaris-icons@7.0.0

## @shopify/polaris-cli@0.1.28

### Patch Changes

-   Updated dependencies \[]:
    -   @shopify/polaris-migrator@0.17.2

## @shopify/polaris-codemods@0.0.3

### Patch Changes

- Updated dependencies
\[[`f1a3ad756`](Shopify@f1a3ad7),
[`80eb3ac55`](Shopify@80eb3ac),
[`dbe68efb4`](Shopify@dbe68ef)]:
    -   @shopify/stylelint-polaris@10.0.0

## @shopify/polaris-migrator@0.17.2

### Patch Changes

- Updated dependencies
\[[`f1a3ad756`](Shopify@f1a3ad7),
[`80eb3ac55`](Shopify@80eb3ac),
[`dbe68efb4`](Shopify@dbe68ef)]:
    -   @shopify/stylelint-polaris@10.0.0

## polaris.shopify.com@0.49.0

### Minor Changes

- [Shopify#8876](Shopify#8876)
[`090d09683`](Shopify@090d096)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters`
to support hiding both filters and search field


- [Shopify#8973](Shopify#8973)
[`f1a3ad756`](Shopify@f1a3ad7)
Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the
`custom-property-disallowed-list` rule and added deprecated v10 custom
properties.


- [Shopify#8967](Shopify#8967)
[`45d978e7b`](Shopify@45d978e)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version
matchup table to `stylelint-polaris` documentation


- [Shopify#8986](Shopify#8986)
[`f70f586ee`](Shopify@f70f586)
Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for
the `react-rename-component` codemod


- [Shopify#8935](Shopify#8935)
[`7f3053342`](Shopify@7f30533)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed
`AlphaStack` to `VerticalStack`


- [Shopify#8920](Shopify#8920)
[`2bad4e305`](Shopify@2bad4e3)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button
to markdown headings with ids

### Patch Changes

- [Shopify#8915](Shopify#8915)
[`c8a130caf`](Shopify@c8a130c)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added
scroll-margin-top to anchor links to prevent top bar overlay


- [Shopify#8455](Shopify#8455)
[`80eb3ac55`](Shopify@80eb3ac)
Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8
custom properties, functions, mixins, and mixin maps from
stylelint-polaris

- Updated dependencies
\[[`a2c9b1d24`](Shopify@a2c9b1d),
[`e8c5a2243`](Shopify@e8c5a22),
[`090d09683`](Shopify@090d096),
[`bd64fa583`](Shopify@bd64fa5),
[`f1a3ad756`](Shopify@f1a3ad7),
[`261355f07`](Shopify@261355f),
[`fcc543928`](Shopify@fcc5439),
[`4880e3ed7`](Shopify@4880e3e),
[`7349d4108`](Shopify@7349d41),
[`2bc90503d`](Shopify@2bc9050),
[`f9366c22d`](Shopify@f9366c2),
[`289dce569`](Shopify@289dce5),
[`7f3053342`](Shopify@7f30533),
[`421bb49dc`](Shopify@421bb49),
[`500eed660`](Shopify@500eed6),
[`1cc47495a`](Shopify@1cc4749)]:
    -   @shopify/polaris@10.44.0
    -   @shopify/polaris-icons@7.0.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@shopify-github-actions-access @github-actions
@alex-page @juzser
Version Packages (Shopify#8993)
a577d6a 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@10.45.0

### Minor Changes

- [Shopify#8910](Shopify#8910)
[`91a9b77e6`](Shopify@91a9b77)
Thanks [@alex-page](https://github.com/alex-page)! - <Box> Replaced
outline, border, borderBlockEnd, borderBlockStart, borderInlineEnd,
borderInlineStart properties with access to borderColor, borderWidth,
outlineColor and outlineWidth

### Patch Changes

- [Shopify#8990](Shopify#8990)
[`9674cc906`](Shopify@9674cc9)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update tokens
for border of `Tabs` on hover and pressed state to create better quality
interaction.

## @shopify/polaris-cli@0.1.29


## @shopify/polaris-icons@6.13.0

### Minor Changes

- [Shopify#8924](Shopify#8924)
[`4880e3ed7`](Shopify@4880e3e)
Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor
icon

* [Shopify#8861](Shopify#8861)
[`2bc90503d`](Shopify@2bc9050)
Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added
ExploreImagesMajor

- [Shopify#8919](Shopify#8919)
[`7349d4108`](Shopify@7349d41)
Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard
major + minor icons



## polaris.shopify.com@0.49.1

### Patch Changes

- Updated dependencies
\[[`9674cc906`](Shopify@9674cc9),
[`91a9b77e6`](Shopify@91a9b77)]:
    -   @shopify/polaris@10.45.0

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alex Page <hi@alexpage.dev>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@AlejandroE @kyledurand
Add explore images icon (Shopify#8861)
3dc9640 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

closes: Shopify#8862

Adds a new icon to represent the menu action opening free (burst) images
in OSE

<img width="244" alt="New-Icon"
src="https://user-images.githubusercontent.com/103959854/229194990-c575b1de-fdb6-4d3e-bcf0-9e5f8d3a5739.png">

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [x] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [x] Updated the component's `README.md` with documentation changes
- [x] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
ascherkus pushed a commit to ascherkus/polaris that referenced this pull request Feb 19, 2025
@shopify-github-actions-access @github-actions
Version Packages (Shopify#8929)
11076d8 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@7.0.0

### Major Changes

- [Shopify#8919](Shopify#8919)
[`7349d4108`](Shopify@e29f62e)
Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard
major + minor icons

### Minor Changes

- [Shopify#8924](Shopify#8924)
[`4880e3ed7`](Shopify@1ad1a62)
Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor
icon


- [Shopify#8861](Shopify#8861)
[`2bc90503d`](Shopify@3dc9640)
Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added
ExploreImagesMajor

## @shopify/stylelint-polaris@10.0.0

### Major Changes

- [Shopify#8973](Shopify#8973)
[`f1a3ad756`](Shopify@05d41ad)
Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the
`custom-property-disallowed-list` rule and added deprecated v10 custom
properties.


- [Shopify#8455](Shopify#8455)
[`80eb3ac55`](Shopify@cc8c04e)
Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8
custom properties, functions, mixins, and mixin maps from
stylelint-polaris

### Minor Changes

- [Shopify#8968](Shopify#8968)
[`dbe68efb4`](Shopify@af07125)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added
`custom-property-disallowed-list` rule

## @shopify/polaris@10.44.0

### Minor Changes

- [Shopify#8936](Shopify#8936)
[`a2c9b1d24`](Shopify@085d3f7)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to
HorizontalStack


- [Shopify#8773](Shopify#8773)
[`e8c5a2243`](Shopify@58136bc)
Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an
optional `onSpinnerChange` prop to`TextField`
    -   Added an optional `largeStep` prop to `TextField`
- Added `TextField` `Spinner` keypress interactions for Home, End, Page
Up, Page Down


- [Shopify#8876](Shopify#8876)
[`090d09683`](Shopify@7e46d7e)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters`
to support hiding both filters and search field


- [Shopify#8973](Shopify#8973)
[`f1a3ad756`](Shopify@05d41ad)
Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the
`custom-property-disallowed-list` rule and added deprecated v10 custom
properties.


- [Shopify#8937](Shopify#8937)
[`fcc543928`](Shopify@6e0bb48)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns`
to `HorizontalGrid`


- [Shopify#8938](Shopify#8938)
[`289dce569`](Shopify@6d46f59)
Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation
from `Grid` component


- [Shopify#8935](Shopify#8935)
[`7f3053342`](Shopify@4ccc28a)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed
`AlphaStack` to `VerticalStack`


- [Shopify#8596](Shopify#8596)
[`421bb49dc`](Shopify@bc813c0)
Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix
minimum height overflowing in iOS Webkit browsers


- [Shopify#8953](Shopify#8953)
[`500eed660`](Shopify@1dc66ee)
Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added
`customActivator` prop to `TopBar.UserMenu`
- Added support for setting a `ReactNode` on `ActionList` `Section`
`title`

### Patch Changes

- [Shopify#8842](Shopify#8842)
[`bd64fa583`](Shopify@b916015)
Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the
Exiting animation state from Popovers, causing them to close immediately
instead of after a 100ms delay.


- [Shopify#8913](Shopify#8913)
[`261355f07`](Shopify@ee7c076)
Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical
alignment of elements within the `AlphaFilters` component


- [Shopify#8954](Shopify#8954)
[`f9366c22d`](Shopify@4345b34)
Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property
names to align with new component names for `HorizontalGrid`,
`HorizontalStack`, and `VerticalStack`


- [Shopify#8912](Shopify#8912)
[`1cc47495a`](Shopify@6d47345)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions`
to include wrapping tooltip on Popover activator

- Updated dependencies
\[[`4880e3ed7`](Shopify@1ad1a62),
[`7349d4108`](Shopify@e29f62e),
[`2bc90503d`](Shopify@3dc9640)]:
    -   @shopify/polaris-icons@7.0.0

## @shopify/polaris-cli@0.1.28

### Patch Changes

-   Updated dependencies \[]:
    -   @shopify/polaris-migrator@0.17.2

## @shopify/polaris-codemods@0.0.3

### Patch Changes

- Updated dependencies
\[[`f1a3ad756`](Shopify@05d41ad),
[`80eb3ac55`](Shopify@cc8c04e),
[`dbe68efb4`](Shopify@af07125)]:
    -   @shopify/stylelint-polaris@10.0.0

## @shopify/polaris-migrator@0.17.2

### Patch Changes

- Updated dependencies
\[[`f1a3ad756`](Shopify@05d41ad),
[`80eb3ac55`](Shopify@cc8c04e),
[`dbe68efb4`](Shopify@af07125)]:
    -   @shopify/stylelint-polaris@10.0.0

## polaris.shopify.com@0.49.0

### Minor Changes

- [Shopify#8876](Shopify#8876)
[`090d09683`](Shopify@7e46d7e)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters`
to support hiding both filters and search field


- [Shopify#8973](Shopify#8973)
[`f1a3ad756`](Shopify@05d41ad)
Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the
`custom-property-disallowed-list` rule and added deprecated v10 custom
properties.


- [Shopify#8967](Shopify#8967)
[`45d978e7b`](Shopify@ab4bbed)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version
matchup table to `stylelint-polaris` documentation


- [Shopify#8986](Shopify#8986)
[`f70f586ee`](Shopify@c488159)
Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for
the `react-rename-component` codemod


- [Shopify#8935](Shopify#8935)
[`7f3053342`](Shopify@4ccc28a)
Thanks [@alex-page](https://github.com/alex-page)! - Renamed
`AlphaStack` to `VerticalStack`


- [Shopify#8920](Shopify#8920)
[`2bad4e305`](Shopify@751027b)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button
to markdown headings with ids

### Patch Changes

- [Shopify#8915](Shopify#8915)
[`c8a130caf`](Shopify@8a81b6a)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added
scroll-margin-top to anchor links to prevent top bar overlay


- [Shopify#8455](Shopify#8455)
[`80eb3ac55`](Shopify@cc8c04e)
Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8
custom properties, functions, mixins, and mixin maps from
stylelint-polaris

- Updated dependencies
\[[`a2c9b1d24`](Shopify@085d3f7),
[`e8c5a2243`](Shopify@58136bc),
[`090d09683`](Shopify@7e46d7e),
[`bd64fa583`](Shopify@b916015),
[`f1a3ad756`](Shopify@05d41ad),
[`261355f07`](Shopify@ee7c076),
[`fcc543928`](Shopify@6e0bb48),
[`4880e3ed7`](Shopify@1ad1a62),
[`7349d4108`](Shopify@e29f62e),
[`2bc90503d`](Shopify@3dc9640),
[`f9366c22d`](Shopify@4345b34),
[`289dce569`](Shopify@6d46f59),
[`7f3053342`](Shopify@4ccc28a),
[`421bb49dc`](Shopify@bc813c0),
[`500eed660`](Shopify@1dc66ee),
[`1cc47495a`](Shopify@6d47345)]:
    -   @shopify/polaris@10.44.0
    -   @shopify/polaris-icons@7.0.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ascherkus pushed a commit to ascherkus/polaris that referenced this pull request Feb 19, 2025
@shopify-github-actions-access @github-actions @alex-page
Version Packages (Shopify#8993)
1230b84 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@10.45.0

### Minor Changes

- [Shopify#8910](Shopify#8910)
[`91a9b77e6`](Shopify@9e5876e)
Thanks [@alex-page](https://github.com/alex-page)! - <Box> Replaced
outline, border, borderBlockEnd, borderBlockStart, borderInlineEnd,
borderInlineStart properties with access to borderColor, borderWidth,
outlineColor and outlineWidth

### Patch Changes

- [Shopify#8990](Shopify#8990)
[`9674cc906`](Shopify@807c9d8)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update tokens
for border of `Tabs` on hover and pressed state to create better quality
interaction.

## @shopify/polaris-cli@0.1.29


## @shopify/polaris-icons@6.13.0

### Minor Changes

- [Shopify#8924](Shopify#8924)
[`4880e3ed7`](Shopify@1ad1a62)
Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor
icon

* [Shopify#8861](Shopify#8861)
[`2bc90503d`](Shopify@3dc9640)
Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added
ExploreImagesMajor

- [Shopify#8919](Shopify#8919)
[`7349d4108`](Shopify@e29f62e)
Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard
major + minor icons



## polaris.shopify.com@0.49.1

### Patch Changes

- Updated dependencies
\[[`9674cc906`](Shopify@807c9d8),
[`91a9b77e6`](Shopify@9e5876e)]:
    -   @shopify/polaris@10.45.0

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alex Page <hi@alexpage.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyledurand kyledurand kyledurand approved these changes

+1 more reviewer

@martenbjork martenbjork martenbjork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🤖Skip Comment Check Skip the migrator comment CI check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Icon]: New icon <ExploreImages>

5 participants

@AlejandroE @osamaghazal01 @heyjoethomas @martenbjork @kyledurand