-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add personalized text icon #8924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
…olaris into personalized-text-icon
kyledurand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good but I think the tests will fail because there's some stuff that can be removed from the markup. Let me know if you need a hand with it
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" fill="none"><g fill="#616A75" clip-path="url(#a)"><path d="M2.707 9.707A.996.996 0 0 0 3 9V5a1 1 0 0 1 1-1 1 1 0 0 0 0-2C2.346 2 1 3.346 1 5v3.586l-.707.707a.999.999 0 0 0 0 1.414l.707.707V15c0 1.654 1.346 3 3 3a1 1 0 0 0 0-2 1 1 0 0 1-1-1v-4a.997.997 0 0 0-.293-.707L2.414 10l.293-.293ZM19.924 9.617a1 1 0 0 0-.217-.324L19 8.586V5c0-1.654-1.346-3-3-3a1 1 0 1 0 0 2 1 1 0 0 1 1 1v4a.996.996 0 0 0 .293.707l.293.293-.293.293A.996.996 0 0 0 17 11v4a1 1 0 0 1-1 1 1 1 0 0 0 0 2c1.654 0 3-1.346 3-3v-3.586l.707-.707a1 1 0 0 0 .217-1.09ZM10 9a2.5 2.5 0 1 0 0-5 2.5 2.5 0 0 0 0 5Z"/><path d="M5 13.375c0 1.036.84 1.875 1.875 1.875h6.25c1.036 0 1.875-.84 1.875-1.875 0-1.036-.937-3.125-5-3.125-4.062 0-5 2.09-5 3.125Z"/></g><defs><clipPath id="a"><path fill="#fff" d="M0 0h20v20H0z"/></clipPath></defs></svg> No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still going to fail our icon checks.
The fill of #fff isn't allowed, only fills of #5C5F62 are allowed. I think the fill="none" can be removed.
width and height attrs should be removed
I don't think the clip path will pass either. Make sure the icon was exported as a flat icon without extra layers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @kyledurand !
Trying to make sure I export things correctely from figma. I removed the background fill, but not sure what I need to do to optimize for the following:
- width and height attrs should be removed
- I don't think the clip path will pass either. Make sure the icon was exported as a flat icon without extra layers.
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
94fccd3 to
b61e79f
Compare
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.0.0 ### Major Changes - [#8919](#8919) [`7349d4108`](7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [#8924](#8924) [`4880e3ed7`](4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [#8861](#8861) [`2bc90503d`](2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/stylelint-polaris@10.0.0 ### Major Changes - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8455](#8455) [`80eb3ac55`](80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [#8968](#8968) [`dbe68efb4`](dbe68ef) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/polaris@10.44.0 ### Minor Changes - [#8936](#8936) [`a2c9b1d24`](a2c9b1d) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [#8773](#8773) [`e8c5a2243`](e8c5a22) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [#8876](#8876) [`090d09683`](090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8937](#8937) [`fcc543928`](fcc5439) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [#8938](#8938) [`289dce569`](289dce5) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [#8935](#8935) [`7f3053342`](7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [#8596](#8596) [`421bb49dc`](421bb49) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [#8953](#8953) [`500eed660`](500eed6) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [#8842](#8842) [`bd64fa583`](bd64fa5) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [#8913](#8913) [`261355f07`](261355f) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [#8954](#8954) [`f9366c22d`](f9366c2) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [#8912](#8912) [`1cc47495a`](1cc4749) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](4880e3e), [`7349d4108`](7349d41), [`2bc90503d`](2bc9050)]: - @shopify/polaris-icons@7.0.0 ## @shopify/polaris-cli@0.1.28 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.17.2 ## @shopify/polaris-codemods@0.0.3 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](f1a3ad7), [`80eb3ac55`](80eb3ac), [`dbe68efb4`](dbe68ef)]: - @shopify/stylelint-polaris@10.0.0 ## @shopify/polaris-migrator@0.17.2 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](f1a3ad7), [`80eb3ac55`](80eb3ac), [`dbe68efb4`](dbe68ef)]: - @shopify/stylelint-polaris@10.0.0 ## polaris.shopify.com@0.49.0 ### Minor Changes - [#8876](#8876) [`090d09683`](090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8967](#8967) [`45d978e7b`](45d978e) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [#8986](#8986) [`f70f586ee`](f70f586) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [#8935](#8935) [`7f3053342`](7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [#8920](#8920) [`2bad4e305`](2bad4e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [#8915](#8915) [`c8a130caf`](c8a130c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [#8455](#8455) [`80eb3ac55`](80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](a2c9b1d), [`e8c5a2243`](e8c5a22), [`090d09683`](090d096), [`bd64fa583`](bd64fa5), [`f1a3ad756`](f1a3ad7), [`261355f07`](261355f), [`fcc543928`](fcc5439), [`4880e3ed7`](4880e3e), [`7349d4108`](7349d41), [`2bc90503d`](2bc9050), [`f9366c22d`](f9366c2), [`289dce569`](289dce5), [`7f3053342`](7f30533), [`421bb49dc`](421bb49), [`500eed660`](500eed6), [`1cc47495a`](1cc4749)]: - @shopify/polaris@10.44.0 - @shopify/polaris-icons@7.0.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.45.0 ### Minor Changes - [#8910](#8910) [`91a9b77e6`](91a9b77) Thanks [@alex-page](https://github.com/alex-page)! - <Box> Replaced outline, border, borderBlockEnd, borderBlockStart, borderInlineEnd, borderInlineStart properties with access to borderColor, borderWidth, outlineColor and outlineWidth ### Patch Changes - [#8990](#8990) [`9674cc906`](9674cc9) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update tokens for border of `Tabs` on hover and pressed state to create better quality interaction. ## @shopify/polaris-cli@0.1.29 ## @shopify/polaris-icons@6.13.0 ### Minor Changes - [#8924](#8924) [`4880e3ed7`](4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon * [#8861](#8861) [`2bc90503d`](2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor - [#8919](#8919) [`7349d4108`](7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ## polaris.shopify.com@0.49.1 ### Patch Changes - Updated dependencies \[[`9674cc906`](9674cc9), [`91a9b77e6`](91a9b77)]: - @shopify/polaris@10.45.0 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Alex Page <hi@alexpage.dev>
### WHY are these changes introduced? The email team is currently working on adding the magic-ui component in order to allow merchants to generate subject lines using the power of AI. Since the magic icon (green circle) is very similar to the current icon we use for personalized text (purple circle), we decided to create a new icon for personalized text. <img width="1437" alt="Screenshot 2023-04-11 at 9 45 24 PM" src="https://user-images.githubusercontent.com/3673138/231260362-25f3e097-6852-4526-8ff6-d38637eea280.png"> <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.0.0 ### Major Changes - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/stylelint-polaris@10.0.0 ### Major Changes - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [Shopify#8968](Shopify#8968) [`dbe68efb4`](Shopify@dbe68ef) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/polaris@10.44.0 ### Minor Changes - [Shopify#8936](Shopify#8936) [`a2c9b1d24`](Shopify@a2c9b1d) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [Shopify#8773](Shopify#8773) [`e8c5a2243`](Shopify@e8c5a22) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8937](Shopify#8937) [`fcc543928`](Shopify@fcc5439) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [Shopify#8938](Shopify#8938) [`289dce569`](Shopify@289dce5) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8596](Shopify#8596) [`421bb49dc`](Shopify@421bb49) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [Shopify#8953](Shopify#8953) [`500eed660`](Shopify@500eed6) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [Shopify#8842](Shopify#8842) [`bd64fa583`](Shopify@bd64fa5) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [Shopify#8913](Shopify#8913) [`261355f07`](Shopify@261355f) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [Shopify#8954](Shopify#8954) [`f9366c22d`](Shopify@f9366c2) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [Shopify#8912](Shopify#8912) [`1cc47495a`](Shopify@1cc4749) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](Shopify@4880e3e), [`7349d4108`](Shopify@7349d41), [`2bc90503d`](Shopify@2bc9050)]: - @shopify/polaris-icons@7.0.0 ## @shopify/polaris-cli@0.1.28 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.17.2 ## @shopify/polaris-codemods@0.0.3 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@f1a3ad7), [`80eb3ac55`](Shopify@80eb3ac), [`dbe68efb4`](Shopify@dbe68ef)]: - @shopify/stylelint-polaris@10.0.0 ## @shopify/polaris-migrator@0.17.2 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@f1a3ad7), [`80eb3ac55`](Shopify@80eb3ac), [`dbe68efb4`](Shopify@dbe68ef)]: - @shopify/stylelint-polaris@10.0.0 ## polaris.shopify.com@0.49.0 ### Minor Changes - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8967](Shopify#8967) [`45d978e7b`](Shopify@45d978e) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [Shopify#8986](Shopify#8986) [`f70f586ee`](Shopify@f70f586) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8920](Shopify#8920) [`2bad4e305`](Shopify@2bad4e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [Shopify#8915](Shopify#8915) [`c8a130caf`](Shopify@c8a130c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](Shopify@a2c9b1d), [`e8c5a2243`](Shopify@e8c5a22), [`090d09683`](Shopify@090d096), [`bd64fa583`](Shopify@bd64fa5), [`f1a3ad756`](Shopify@f1a3ad7), [`261355f07`](Shopify@261355f), [`fcc543928`](Shopify@fcc5439), [`4880e3ed7`](Shopify@4880e3e), [`7349d4108`](Shopify@7349d41), [`2bc90503d`](Shopify@2bc9050), [`f9366c22d`](Shopify@f9366c2), [`289dce569`](Shopify@289dce5), [`7f3053342`](Shopify@7f30533), [`421bb49dc`](Shopify@421bb49), [`500eed660`](Shopify@500eed6), [`1cc47495a`](Shopify@1cc4749)]: - @shopify/polaris@10.44.0 - @shopify/polaris-icons@7.0.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.45.0 ### Minor Changes - [Shopify#8910](Shopify#8910) [`91a9b77e6`](Shopify@91a9b77) Thanks [@alex-page](https://github.com/alex-page)! - <Box> Replaced outline, border, borderBlockEnd, borderBlockStart, borderInlineEnd, borderInlineStart properties with access to borderColor, borderWidth, outlineColor and outlineWidth ### Patch Changes - [Shopify#8990](Shopify#8990) [`9674cc906`](Shopify@9674cc9) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update tokens for border of `Tabs` on hover and pressed state to create better quality interaction. ## @shopify/polaris-cli@0.1.29 ## @shopify/polaris-icons@6.13.0 ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon * [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ## polaris.shopify.com@0.49.1 ### Patch Changes - Updated dependencies \[[`9674cc906`](Shopify@9674cc9), [`91a9b77e6`](Shopify@91a9b77)]: - @shopify/polaris@10.45.0 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Alex Page <hi@alexpage.dev>
### WHY are these changes introduced? The email team is currently working on adding the magic-ui component in order to allow merchants to generate subject lines using the power of AI. Since the magic icon (green circle) is very similar to the current icon we use for personalized text (purple circle), we decided to create a new icon for personalized text. <img width="1437" alt="Screenshot 2023-04-11 at 9 45 24 PM" src="https://user-images.githubusercontent.com/3673138/231260362-25f3e097-6852-4526-8ff6-d38637eea280.png"> <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.0.0 ### Major Changes - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@e29f62e) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@1ad1a62) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@3dc9640) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/stylelint-polaris@10.0.0 ### Major Changes - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@05d41ad) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@cc8c04e) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [Shopify#8968](Shopify#8968) [`dbe68efb4`](Shopify@af07125) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/polaris@10.44.0 ### Minor Changes - [Shopify#8936](Shopify#8936) [`a2c9b1d24`](Shopify@085d3f7) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [Shopify#8773](Shopify#8773) [`e8c5a2243`](Shopify@58136bc) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@7e46d7e) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@05d41ad) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8937](Shopify#8937) [`fcc543928`](Shopify@6e0bb48) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [Shopify#8938](Shopify#8938) [`289dce569`](Shopify@6d46f59) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@4ccc28a) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8596](Shopify#8596) [`421bb49dc`](Shopify@bc813c0) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [Shopify#8953](Shopify#8953) [`500eed660`](Shopify@1dc66ee) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [Shopify#8842](Shopify#8842) [`bd64fa583`](Shopify@b916015) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [Shopify#8913](Shopify#8913) [`261355f07`](Shopify@ee7c076) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [Shopify#8954](Shopify#8954) [`f9366c22d`](Shopify@4345b34) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [Shopify#8912](Shopify#8912) [`1cc47495a`](Shopify@6d47345) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](Shopify@1ad1a62), [`7349d4108`](Shopify@e29f62e), [`2bc90503d`](Shopify@3dc9640)]: - @shopify/polaris-icons@7.0.0 ## @shopify/polaris-cli@0.1.28 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.17.2 ## @shopify/polaris-codemods@0.0.3 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@05d41ad), [`80eb3ac55`](Shopify@cc8c04e), [`dbe68efb4`](Shopify@af07125)]: - @shopify/stylelint-polaris@10.0.0 ## @shopify/polaris-migrator@0.17.2 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@05d41ad), [`80eb3ac55`](Shopify@cc8c04e), [`dbe68efb4`](Shopify@af07125)]: - @shopify/stylelint-polaris@10.0.0 ## polaris.shopify.com@0.49.0 ### Minor Changes - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@7e46d7e) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@05d41ad) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8967](Shopify#8967) [`45d978e7b`](Shopify@ab4bbed) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [Shopify#8986](Shopify#8986) [`f70f586ee`](Shopify@c488159) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@4ccc28a) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8920](Shopify#8920) [`2bad4e305`](Shopify@751027b) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [Shopify#8915](Shopify#8915) [`c8a130caf`](Shopify@8a81b6a) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@cc8c04e) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](Shopify@085d3f7), [`e8c5a2243`](Shopify@58136bc), [`090d09683`](Shopify@7e46d7e), [`bd64fa583`](Shopify@b916015), [`f1a3ad756`](Shopify@05d41ad), [`261355f07`](Shopify@ee7c076), [`fcc543928`](Shopify@6e0bb48), [`4880e3ed7`](Shopify@1ad1a62), [`7349d4108`](Shopify@e29f62e), [`2bc90503d`](Shopify@3dc9640), [`f9366c22d`](Shopify@4345b34), [`289dce569`](Shopify@6d46f59), [`7f3053342`](Shopify@4ccc28a), [`421bb49dc`](Shopify@bc813c0), [`500eed660`](Shopify@1dc66ee), [`1cc47495a`](Shopify@6d47345)]: - @shopify/polaris@10.44.0 - @shopify/polaris-icons@7.0.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.45.0 ### Minor Changes - [Shopify#8910](Shopify#8910) [`91a9b77e6`](Shopify@9e5876e) Thanks [@alex-page](https://github.com/alex-page)! - <Box> Replaced outline, border, borderBlockEnd, borderBlockStart, borderInlineEnd, borderInlineStart properties with access to borderColor, borderWidth, outlineColor and outlineWidth ### Patch Changes - [Shopify#8990](Shopify#8990) [`9674cc906`](Shopify@807c9d8) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update tokens for border of `Tabs` on hover and pressed state to create better quality interaction. ## @shopify/polaris-cli@0.1.29 ## @shopify/polaris-icons@6.13.0 ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@1ad1a62) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon * [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@3dc9640) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@e29f62e) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ## polaris.shopify.com@0.49.1 ### Patch Changes - Updated dependencies \[[`9674cc906`](Shopify@807c9d8), [`91a9b77e6`](Shopify@9e5876e)]: - @shopify/polaris@10.45.0 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Alex Page <hi@alexpage.dev>
WHY are these changes introduced?
The email team is currently working on adding the magic-ui component in order to allow merchants to generate subject lines using the power of AI. Since the magic icon (green circle) is very similar to the current icon we use for personalized text (purple circle), we decided to create a new icon for personalized text.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes