Make Popover snappier by removing unmount delay
#8842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
martenbjork
changed the title
martenbjork
changed the title
Popover snappier by removing unmount delay
laurkim
approved these changes
Apr 4, 2023
Contributor
|
I feel like we could use the We'd need to update https://github.com/Shopify/polaris/blob/main/polaris-react/src/utilities/ephemeral-presence-manager/context.tsx to also allow |
alex-page
approved these changes
Apr 12, 2023
Contributor
Author
Sounds good! I'll file this as a follow up issue since its only relevant if we decide to add motion back when popovers close. |
Merged
chloerice
pushed a commit
that referenced
this pull request
Apr 17, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.0.0 ### Major Changes - [#8919](#8919) [`7349d4108`](7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [#8924](#8924) [`4880e3ed7`](4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [#8861](#8861) [`2bc90503d`](2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/stylelint-polaris@10.0.0 ### Major Changes - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8455](#8455) [`80eb3ac55`](80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [#8968](#8968) [`dbe68efb4`](dbe68ef) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/polaris@10.44.0 ### Minor Changes - [#8936](#8936) [`a2c9b1d24`](a2c9b1d) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [#8773](#8773) [`e8c5a2243`](e8c5a22) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [#8876](#8876) [`090d09683`](090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8937](#8937) [`fcc543928`](fcc5439) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [#8938](#8938) [`289dce569`](289dce5) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [#8935](#8935) [`7f3053342`](7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [#8596](#8596) [`421bb49dc`](421bb49) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [#8953](#8953) [`500eed660`](500eed6) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [#8842](#8842) [`bd64fa583`](bd64fa5) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [#8913](#8913) [`261355f07`](261355f) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [#8954](#8954) [`f9366c22d`](f9366c2) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [#8912](#8912) [`1cc47495a`](1cc4749) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](4880e3e), [`7349d4108`](7349d41), [`2bc90503d`](2bc9050)]: - @shopify/polaris-icons@7.0.0 ## @shopify/polaris-cli@0.1.28 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.17.2 ## @shopify/polaris-codemods@0.0.3 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](f1a3ad7), [`80eb3ac55`](80eb3ac), [`dbe68efb4`](dbe68ef)]: - @shopify/stylelint-polaris@10.0.0 ## @shopify/polaris-migrator@0.17.2 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](f1a3ad7), [`80eb3ac55`](80eb3ac), [`dbe68efb4`](dbe68ef)]: - @shopify/stylelint-polaris@10.0.0 ## polaris.shopify.com@0.49.0 ### Minor Changes - [#8876](#8876) [`090d09683`](090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8967](#8967) [`45d978e7b`](45d978e) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [#8986](#8986) [`f70f586ee`](f70f586) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [#8935](#8935) [`7f3053342`](7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [#8920](#8920) [`2bad4e305`](2bad4e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [#8915](#8915) [`c8a130caf`](c8a130c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [#8455](#8455) [`80eb3ac55`](80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](a2c9b1d), [`e8c5a2243`](e8c5a22), [`090d09683`](090d096), [`bd64fa583`](bd64fa5), [`f1a3ad756`](f1a3ad7), [`261355f07`](261355f), [`fcc543928`](fcc5439), [`4880e3ed7`](4880e3e), [`7349d4108`](7349d41), [`2bc90503d`](2bc9050), [`f9366c22d`](f9366c2), [`289dce569`](289dce5), [`7f3053342`](7f30533), [`421bb49dc`](421bb49), [`500eed660`](500eed6), [`1cc47495a`](1cc4749)]: - @shopify/polaris@10.44.0 - @shopify/polaris-icons@7.0.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
Popovers currently wait 100ms to unmount. When quickly moving between popovers, it creates the appearance of 2 popovers being visible at the same time, making it hard to know where to focus the attention. https://user-images.githubusercontent.com/875708/229795118-862e67d2-c593-4efc-9b7b-a5436396088e.mp4 <br> This PR removes the unmount delay. This delay exists to create space for an exit animation, but the Popover component doesn't have one, so it simply waits 100ms and then disappears without a transition. With this change, the Popovers feel more snappy: https://user-images.githubusercontent.com/875708/229795143-99930bf8-4cf0-4310-a082-e578affa5d43.mp4 ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.0.0 ### Major Changes - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/stylelint-polaris@10.0.0 ### Major Changes - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [Shopify#8968](Shopify#8968) [`dbe68efb4`](Shopify@dbe68ef) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/polaris@10.44.0 ### Minor Changes - [Shopify#8936](Shopify#8936) [`a2c9b1d24`](Shopify@a2c9b1d) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [Shopify#8773](Shopify#8773) [`e8c5a2243`](Shopify@e8c5a22) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8937](Shopify#8937) [`fcc543928`](Shopify@fcc5439) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [Shopify#8938](Shopify#8938) [`289dce569`](Shopify@289dce5) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8596](Shopify#8596) [`421bb49dc`](Shopify@421bb49) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [Shopify#8953](Shopify#8953) [`500eed660`](Shopify@500eed6) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [Shopify#8842](Shopify#8842) [`bd64fa583`](Shopify@bd64fa5) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [Shopify#8913](Shopify#8913) [`261355f07`](Shopify@261355f) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [Shopify#8954](Shopify#8954) [`f9366c22d`](Shopify@f9366c2) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [Shopify#8912](Shopify#8912) [`1cc47495a`](Shopify@1cc4749) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](Shopify@4880e3e), [`7349d4108`](Shopify@7349d41), [`2bc90503d`](Shopify@2bc9050)]: - @shopify/polaris-icons@7.0.0 ## @shopify/polaris-cli@0.1.28 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.17.2 ## @shopify/polaris-codemods@0.0.3 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@f1a3ad7), [`80eb3ac55`](Shopify@80eb3ac), [`dbe68efb4`](Shopify@dbe68ef)]: - @shopify/stylelint-polaris@10.0.0 ## @shopify/polaris-migrator@0.17.2 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@f1a3ad7), [`80eb3ac55`](Shopify@80eb3ac), [`dbe68efb4`](Shopify@dbe68ef)]: - @shopify/stylelint-polaris@10.0.0 ## polaris.shopify.com@0.49.0 ### Minor Changes - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8967](Shopify#8967) [`45d978e7b`](Shopify@45d978e) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [Shopify#8986](Shopify#8986) [`f70f586ee`](Shopify@f70f586) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8920](Shopify#8920) [`2bad4e305`](Shopify@2bad4e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [Shopify#8915](Shopify#8915) [`c8a130caf`](Shopify@c8a130c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](Shopify@a2c9b1d), [`e8c5a2243`](Shopify@e8c5a22), [`090d09683`](Shopify@090d096), [`bd64fa583`](Shopify@bd64fa5), [`f1a3ad756`](Shopify@f1a3ad7), [`261355f07`](Shopify@261355f), [`fcc543928`](Shopify@fcc5439), [`4880e3ed7`](Shopify@4880e3e), [`7349d4108`](Shopify@7349d41), [`2bc90503d`](Shopify@2bc9050), [`f9366c22d`](Shopify@f9366c2), [`289dce569`](Shopify@289dce5), [`7f3053342`](Shopify@7f30533), [`421bb49dc`](Shopify@421bb49), [`500eed660`](Shopify@500eed6), [`1cc47495a`](Shopify@1cc4749)]: - @shopify/polaris@10.44.0 - @shopify/polaris-icons@7.0.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Popovers currently wait 100ms to unmount. When quickly moving between popovers, it creates the appearance of 2 popovers being visible at the same time, making it hard to know where to focus the attention. https://user-images.githubusercontent.com/875708/229795118-862e67d2-c593-4efc-9b7b-a5436396088e.mp4 <br> This PR removes the unmount delay. This delay exists to create space for an exit animation, but the Popover component doesn't have one, so it simply waits 100ms and then disappears without a transition. With this change, the Popovers feel more snappy: https://user-images.githubusercontent.com/875708/229795143-99930bf8-4cf0-4310-a082-e578affa5d43.mp4 ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.0.0 ### Major Changes - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@e29f62e) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@1ad1a62) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@3dc9640) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/stylelint-polaris@10.0.0 ### Major Changes - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@05d41ad) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@cc8c04e) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [Shopify#8968](Shopify#8968) [`dbe68efb4`](Shopify@af07125) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/polaris@10.44.0 ### Minor Changes - [Shopify#8936](Shopify#8936) [`a2c9b1d24`](Shopify@085d3f7) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [Shopify#8773](Shopify#8773) [`e8c5a2243`](Shopify@58136bc) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@7e46d7e) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@05d41ad) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8937](Shopify#8937) [`fcc543928`](Shopify@6e0bb48) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [Shopify#8938](Shopify#8938) [`289dce569`](Shopify@6d46f59) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@4ccc28a) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8596](Shopify#8596) [`421bb49dc`](Shopify@bc813c0) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [Shopify#8953](Shopify#8953) [`500eed660`](Shopify@1dc66ee) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [Shopify#8842](Shopify#8842) [`bd64fa583`](Shopify@b916015) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [Shopify#8913](Shopify#8913) [`261355f07`](Shopify@ee7c076) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [Shopify#8954](Shopify#8954) [`f9366c22d`](Shopify@4345b34) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [Shopify#8912](Shopify#8912) [`1cc47495a`](Shopify@6d47345) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](Shopify@1ad1a62), [`7349d4108`](Shopify@e29f62e), [`2bc90503d`](Shopify@3dc9640)]: - @shopify/polaris-icons@7.0.0 ## @shopify/polaris-cli@0.1.28 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.17.2 ## @shopify/polaris-codemods@0.0.3 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@05d41ad), [`80eb3ac55`](Shopify@cc8c04e), [`dbe68efb4`](Shopify@af07125)]: - @shopify/stylelint-polaris@10.0.0 ## @shopify/polaris-migrator@0.17.2 ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@05d41ad), [`80eb3ac55`](Shopify@cc8c04e), [`dbe68efb4`](Shopify@af07125)]: - @shopify/stylelint-polaris@10.0.0 ## polaris.shopify.com@0.49.0 ### Minor Changes - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@7e46d7e) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@05d41ad) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8967](Shopify#8967) [`45d978e7b`](Shopify@ab4bbed) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [Shopify#8986](Shopify#8986) [`f70f586ee`](Shopify@c488159) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@4ccc28a) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8920](Shopify#8920) [`2bad4e305`](Shopify@751027b) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [Shopify#8915](Shopify#8915) [`c8a130caf`](Shopify@8a81b6a) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@cc8c04e) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](Shopify@085d3f7), [`e8c5a2243`](Shopify@58136bc), [`090d09683`](Shopify@7e46d7e), [`bd64fa583`](Shopify@b916015), [`f1a3ad756`](Shopify@05d41ad), [`261355f07`](Shopify@ee7c076), [`fcc543928`](Shopify@6e0bb48), [`4880e3ed7`](Shopify@1ad1a62), [`7349d4108`](Shopify@e29f62e), [`2bc90503d`](Shopify@3dc9640), [`f9366c22d`](Shopify@4345b34), [`289dce569`](Shopify@6d46f59), [`7f3053342`](Shopify@4ccc28a), [`421bb49dc`](Shopify@bc813c0), [`500eed660`](Shopify@1dc66ee), [`1cc47495a`](Shopify@6d47345)]: - @shopify/polaris@10.44.0 - @shopify/polaris-icons@7.0.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popovers currently wait 100ms to unmount. When quickly moving between popovers, it creates the appearance of 2 popovers being visible at the same time, making it hard to know where to focus the attention.
sluggish-popovers.mp4
This PR removes the unmount delay. This delay exists to create space for an exit animation, but the Popover component doesn't have one, so it simply waits 100ms and then disappears without a transition.
With this change, the Popovers feel more snappy:
fast-popovers.mp4
🎩 checklist
README.mdwith documentation changes