Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

🐛 Update Router to 1. always take in location, 2. use location.href i…#1567

Merged
michenly merged 1 commit intomasterfrom
router-update
Jul 28, 2020
Merged

🐛 Update Router to 1. always take in location, 2. use location.href i…#1567
michenly merged 1 commit intomasterfrom
router-update

Conversation

@michenly
Copy link
Contributor

@michenly michenly commented Jul 28, 2020

…f location is an object

Description

To reproduce the error

  1. load up https://github.com/Shopify/gestalt-web-application-example
  2. Goto / url to see

Screen Shot 2020-07-28 at 1 46 59 PM

3. Goto `/test123` to see

Screen Shot 2020-07-28 at 1 47 07 PM

4. Remove wrapping from `NotFound.tsx` and reload `/test123` 5. See the following page with the incorrect image

Screen Shot 2020-07-28 at 1 49 16 PM

and see browser error

Screen Shot 2020-07-28 at 1 49 22 PM

To check the error is fix
6. quit gestalt-web-application-example server
6. in quilt folder , run command yarn build && yarn tophat react-router ../gestalt-web-application-example
7. dev s in gestalt-web-application-example server folder
8. reload /test123
9. See the expected image below and no react miss-match error in browser
Screen Shot 2020-07-28 at 1 52 33 PM

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@michenly michenly self-assigned this Jul 28, 2020
Copy link
Contributor

@marutypes marutypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michenly michenly merged commit 9c2a586 into master Jul 28, 2020
@michenly michenly deleted the router-update branch July 28, 2020 18:59
@michenly michenly temporarily deployed to production July 28, 2020 19:21 Inactive
@gmcgibbon gmcgibbon temporarily deployed to gem August 10, 2020 19:08 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants