This repository was archived by the owner on Jan 10, 2025. It is now read-only.
🐛 Update Router to 1. always take in location, 2. use location.href i…#1567
Merged
🐛 Update Router to 1. always take in location, 2. use location.href i…#1567
Conversation
…f location is an object
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…f location is an object
Description
To reproduce the error
/url to see
3. Goto `/test123` to see
4. Remove wrapping from `NotFound.tsx` and reload `/test123` 5. See the following page with the incorrect image
and see browser errorTo check the error is fix

6. quit gestalt-web-application-example server
6. in quilt folder , run command
yarn build && yarn tophat react-router ../gestalt-web-application-example7.
dev sin gestalt-web-application-example server folder8. reload
/test1239. See the expected image below and no react miss-match error in browser
Type of change
Checklist