Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

🎨 Refactor useDelayedCallback unit test#1601

Merged
carolopolo merged 1 commit intomasterfrom
reactHooks/improve-test-for-use-delayed-callback
Aug 19, 2020
Merged

🎨 Refactor useDelayedCallback unit test#1601
carolopolo merged 1 commit intomasterfrom
reactHooks/improve-test-for-use-delayed-callback

Conversation

@carolopolo
Copy link
Contributor

@carolopolo carolopolo commented Aug 19, 2020

Description

Just a small patch to improve a unit test

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@carolopolo carolopolo self-assigned this Aug 19, 2020
@carolopolo carolopolo force-pushed the reactHooks/improve-test-for-use-delayed-callback branch from f37ee9e to d541645 Compare August 19, 2020 15:18
@carolopolo carolopolo requested a review from loic-d August 19, 2020 15:18
@loic-d loic-d requested a review from mathieulag August 19, 2020 15:23
fakeComponent.act(() => {
clock.tick(1.5 * delay);
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more false positive 😄 👍

Copy link
Contributor

@loic-d loic-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carolopolo carolopolo merged commit fc84aa4 into master Aug 19, 2020
@carolopolo carolopolo deleted the reactHooks/improve-test-for-use-delayed-callback branch August 19, 2020 16:07
Copy link
Contributor

@mathieulag mathieulag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@michenly michenly temporarily deployed to production August 19, 2020 23:05 Inactive
@gmcgibbon gmcgibbon temporarily deployed to gem August 24, 2020 19:15 Inactive
@ismail-syed ismail-syed deployed to pr-fix-beta-test August 31, 2020 15:04 Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants