This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Fix forceUpdate() for RR6 data routes with loaders#2709
Merged
Conversation
mattkubej
approved these changes
Jan 30, 2024
melnikov-s
approved these changes
Jan 30, 2024
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @melnikov-s! Your snapshot has been published to npm. Test the snapshot by updating your yarn add @shopify/react-testing@0.0.0-snapshot-20240131005345 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
React Router data routes don't render in a single pass, so forceUpdate() of a parent component does not force-update matched components. This means that React will bail out of rendering when it hits
rootElementinTestWrapperbecause it is equal to the previous render.