Skip to content

Use the selected chat model for the Ruby design agent - #4193

Open
Hashim1999164 wants to merge 1 commit into
Shopify:mainfrom
Hashim1999164:fix/chat-agent-custom-model
Open

Use the selected chat model for the Ruby design agent#4193
Hashim1999164 wants to merge 1 commit into
Shopify:mainfrom
Hashim1999164:fix/chat-agent-custom-model

Conversation

@Hashim1999164

@Hashim1999164 Hashim1999164 commented Aug 18, 2026

Copy link
Copy Markdown

Summary

  • The design chat agent always asked vscode.lm.selectChatModels for Copilot GPT4o, so custom chat models left model undefined and sendRequest crashed
  • It now uses the model already selected for the chat, falls back to Copilot GPT4o if needed, and shows a message instead of throwing when no model is available

Closes #4186

Tests

  • npx tsc covering the vscode extension

@Hashim1999164
Hashim1999164 requested a review from a team as a code owner August 18, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'sendRequest')

1 participant