Enable cops in the Naming department #764
Conversation
github-actions
bot
added
the
config change
rafaelfranca
force-pushed
the
rm-naming-department
branch
2 times, most recently
from
106f40b to
ce85b4b
Compare
- [Naming/BlockParameterName](https://docs.rubocop.org/rubocop/cops_naming.html#namingblockparametername) - [Naming/ClassAndModuleCamelCase](https://docs.rubocop.org/rubocop/cops_naming.html#namingclassandmodulecamelcase) - [Naming/ConstantName](https://docs.rubocop.org/rubocop/cops_naming.html#namingconstantname) - [Naming/HeredocDelimiterCase](https://docs.rubocop.org/rubocop/cops_naming.html#namingheredocdelimitercase) - [Naming/MethodName](https://docs.rubocop.org/rubocop/cops_naming.html#namingmethodname) - [Naming/MethodParameterName](https://docs.rubocop.org/rubocop/cops_naming.html#namingmethodparametername) - [Naming/VariableName](https://docs.rubocop.org/rubocop/cops_naming.html#namingvariablename)
rafaelfranca
force-pushed
the
rm-naming-department
branch
from
ce85b4b to
117885b
Compare
| VersionAdded: '0.53' | ||
| VersionChanged: '0.77' | ||
| MinNameLength: 3 | ||
| MinNameLength: 1 |
There was a problem hiding this comment.
What's the rationale for this? One would encourage names like x and y, right?
There was a problem hiding this comment.
I can see how sometimes that might be needed though:
class Point
def initialize(x, y)
@x = x
@y = y
end
endThere was a problem hiding this comment.
I think this cop will little value with MinNameLength: 1. What if, instead, we add to AllowedNames?
AllowedNames:
# (merged with default list, including `id`, `db`, etc.)
- a
- b
- c
- x
- y
- zAnother option is for the cop to simply be disabled when it is a bad fit
Exclude:
- /path/to/point.rb
- /path/to/geometry/**
There was a problem hiding this comment.
We should not care about the size. What we are trying to get here is camelCase arguments that I found when enabling this cop.
sambostock
left a comment
sambostock
left a comment
There was a problem hiding this comment.
Couple thoughts, but no blockers.
| AllowedPatterns: | ||
| - "\\Atest_" |
There was a problem hiding this comment.
Why remove this? Don't we want to permit descriptive test names?
def test_rejects_HTTP_requests = ...
def test_accepts_HTTPS_requests = ...Not every project uses ActiveSupport::TestCase.
There was a problem hiding this comment.
there is no reason to use acronyms in the test name. Just write everything downcased.
4 participants
Uh oh!
There was an error while loading. Please reload this page.