Skip to content

Refresh dependencies for all adapters and fix time helper#941

Merged
AbdulRahmanAlHamali merged 2 commits into
mainfrom
refresh-dependencies
Dec 19, 2025
Merged

Refresh dependencies for all adapters and fix time helper#941
AbdulRahmanAlHamali merged 2 commits into
mainfrom
refresh-dependencies

Conversation

@AbdulRahmanAlHamali

@AbdulRahmanAlHamali AbdulRahmanAlHamali commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

CI has been failing on all PRs for a while now. Example

https://github.com/Shopify/semian/actions/runs/20375211600/job/58551769047?pr=760

The reason is twofold:

  1. We are stubbing all calls to clock_gettime, even the ones we are not really calling, and that are totally irrelevant to our code path.
  2. This was only detected recently because the postgre adapter that was added, did not have a lock in the gemfile, so it started picking up a version of rails that has some calls to clock_gettime, and this is when the problem floated.

This PR is doing two things:

  1. Running a bundle update for all our adapters, which updates them and also adds the missing lock file
  2. Fixes the CI failure by making sure we are only stubbing the part that makes sense. The fix is hacky, but Mocha did not allow me a better approach (I researched this for a couple of hours and nothing worked)

@AbdulRahmanAlHamali AbdulRahmanAlHamali self-assigned this Dec 19, 2025
@AbdulRahmanAlHamali AbdulRahmanAlHamali force-pushed the refresh-dependencies branch 8 times, most recently from 19e8399 to c91be78 Compare December 19, 2025 16:09
@AbdulRahmanAlHamali AbdulRahmanAlHamali changed the title Refresh dependencies for all adapters Refresh dependencies for all adapters and fix time helper Dec 19, 2025
@AbdulRahmanAlHamali AbdulRahmanAlHamali merged commit 3c3cbe0 into main Dec 19, 2025
35 checks passed
@AbdulRahmanAlHamali AbdulRahmanAlHamali deleted the refresh-dependencies branch December 19, 2025 18:54

private

def fake_stub_all_clock_gettime_behaviour

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit verbose. It seems to pass if you omit arguments from the stub, or use a helper and stub that instead.

beepubapu pushed a commit that referenced this pull request Jan 5, 2026
* refresh dependencies for all adapters

* only stub monotonic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants