Refresh dependencies for all adapters and fix time helper#941
Merged
Conversation
19e8399 to
c91be78
Compare
c91be78 to
a0a00eb
Compare
adriangudas
approved these changes
Dec 19, 2025
gmcgibbon
reviewed
Dec 19, 2025
|
|
||
| private | ||
|
|
||
| def fake_stub_all_clock_gettime_behaviour |
Member
There was a problem hiding this comment.
This is a bit verbose. It seems to pass if you omit arguments from the stub, or use a helper and stub that instead.
beepubapu
pushed a commit
that referenced
this pull request
Jan 5, 2026
* refresh dependencies for all adapters * only stub monotonic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI has been failing on all PRs for a while now. Example
https://github.com/Shopify/semian/actions/runs/20375211600/job/58551769047?pr=760
The reason is twofold:
clock_gettime, even the ones we are not really calling, and that are totally irrelevant to our code path.clock_gettime, and this is when the problem floated.This PR is doing two things: