This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Allow loading offline sessions from loadCurrentSession#119
Merged
Conversation
paulomarg
force-pushed
the
load_offline_sessions_from_requests
branch
from
dfa1a37 to
ac9c03c
Compare
paulomarg
force-pushed
the
load_offline_sessions_from_requests
branch
from
a007bce to
4db4974
Compare
mkevinosullivan
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Currently, the
loadCurrentSessionmethod doesn't allow loading offline sessions from the request, which is desired for some apps.WHAT is this pull request doing?
Adding an optional parameter (defaulting to online) to allow returning offline sessions as well as online ones.
Type of change
Checklist