This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Throw specific error for missing cookies on OAuth#131
Merged
Conversation
paulomarg
force-pushed
the
throw_specific_cookie_error_on_oauth
branch
from
08b8fc3 to
3a08fd3
Compare
|
@paulomarg thanks for this! When should we expect new release tag for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
As mentioned on Shopify/koa-shopify-auth#61 (comment), we were throwing the same error (
SessionNotFound) if the session itself was missing, or if the cookie the holds its id was missing, which can be confusing when errors happen.WHAT is this pull request doing?
Throwing a specific
CookieNotFounderror if we can't load the session id from the cookie to make it easier to surface issues to apps.Type of change
Checklist
I have documented new APIs/updated the documentation for modified APIs (for public APIs)