Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

[WIP] Ensure scopes defined in scopes.equals()#160

Closed
carmelal wants to merge 1 commit intomainfrom
validate-scopes
Closed

[WIP] Ensure scopes defined in scopes.equals()#160
carmelal wants to merge 1 commit intomainfrom
validate-scopes

Conversation

@carmelal
Copy link
Copy Markdown
Contributor

@carmelal carmelal commented Apr 9, 2021

Why are these changes introduced? 🤔

What is this pull request doing? 📋

  • Checks scopes exist before doing the rest of equals()

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@carmelal
Copy link
Copy Markdown
Contributor Author

Closing this PR as it is a band-aid solution. PR #169 addresses the root issue.

@carmelal carmelal closed this Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session scope check fails when scope is undefined

1 participant