Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Fix incorrect example in webhook register docs#183

Merged
tbrenev merged 1 commit intomainfrom
webhook-doc-fix
May 25, 2021
Merged

Fix incorrect example in webhook register docs#183
tbrenev merged 1 commit intomainfrom
webhook-doc-fix

Conversation

@tbrenev
Copy link
Copy Markdown
Contributor

@tbrenev tbrenev commented May 25, 2021

WHY are these changes introduced?

Noticed that I made a small error in the docs in #181 - it's minor, but could be very confusing for someone reading the docs for the first time.

WHAT is this pull request doing?

Just a tiny fix to the docs.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

(don't think that we need a changelog entry for this, definitely don't need tests)

@tbrenev tbrenev requested a review from a team as a code owner May 25, 2021 13:55
Copy link
Copy Markdown
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tbrenev tbrenev merged commit 0397e56 into main May 25, 2021
@tbrenev tbrenev deleted the webhook-doc-fix branch May 25, 2021 15:15
@shopify-shipit shopify-shipit Bot temporarily deployed to production June 11, 2021 17:36 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants