This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Change broken endpoint#200
Merged
Paulinakhew merged 2 commits intomainfrom Jun 16, 2021
Merged
Conversation
paulomarg
reviewed
Jun 14, 2021
| </details> | ||
|
|
||
| After process is completed, you can navigate to `{your ngrok address}/oauth/begin` in your browser to begin OAuth. When it completes, you will have a Shopify session that enables you to make requests to the Admin API, as detailed next. | ||
| After process is completed, you can navigate to `{your ngrok address}/auth/callback` in your browser to begin OAuth. When it completes, you will have a Shopify session that enables you to make requests to the Admin API, as detailed next. |
Contributor
There was a problem hiding this comment.
I think we should actually be going to /login here, though?
Contributor
There was a problem hiding this comment.
+1, the actual endpoint in the app should be /login, which will initiate the auth flow.
Contributor
Author
There was a problem hiding this comment.
😓 oops that's right, I fixed it
paulomarg
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
WHAT is this pull request doing?
Type of change
Checklist