This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Fix jwt not active error by adding a small clock tolerence#227
Merged
mllemango merged 2 commits intoShopify:v2from Oct 26, 2021
tolgap:clock-tolerance
Merged
Fix jwt not active error by adding a small clock tolerence#227mllemango merged 2 commits intoShopify:v2from tolgap:clock-tolerance
jwt not active error by adding a small clock tolerence#227mllemango merged 2 commits intoShopify:v2from
tolgap:clock-tolerance
Conversation
|
Any updates on this? This seems a blocker to move to latest shopify pkgs. |
mllemango
approved these changes
Oct 26, 2021
Contributor
|
Thanks for fixing this! We’re packaging this into our v2 branch for release soon 😄 |
1 task
This was referenced Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #207
auth0/node-jsonwebtokensupports aclockToleranceoption for small differences between machines on the internet. There are multiple users complaining about running intojwt not activeerrors.WHAT is this pull request doing?
Uses the
clockToleranceoption fromauth0/node-jsonwebtoken. Sets it at a respectable 5 seconds. All my issues where small differences from 4 seconds to 2 seconds.Type of change
Checklist