This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Include query body in API deprecation logs#426
Merged
Conversation
b5fc785 to
251bb0d
Compare
251bb0d to
223d546
Compare
mkevinosullivan
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to Shopify/cli#156
Currently, we're logging deprecation notices, but for the GraphQL API, we don't get a lot of details - since every request lands in the same endpoint, there's no way to tell them apart.
WHAT is this pull request doing?
Adding the first 100 characters from the body (if one exists) to help indicate which query is triggering the logs, to make it easier for developers to figure out where they're hitting deprecated fields.
Type of change
Checklist