This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Add methods to sanitize shops and hosts#434
Merged
Conversation
ff3470c to
af46302
Compare
mkevinosullivan
approved these changes
Jul 26, 2022
4d67065 to
090a1fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When receiving user input data, apps should be able to easily validate that they are in the expected format / safe.
WHAT is this pull request doing?
Adding Utils methods
sanitizeShopandsanitizeHostto make it easier for apps to validate / fail requests on a single call.I ended up opting not to reuse
validateShopbecause I like the ergonomics ofbetter than
Type of change
Checklist