This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Pass in User-Agent header in PUT / POST requests#435
Merged
Conversation
paulomarg
force-pushed
the
fix_post_put_headers
branch
from
84a5722 to
0cfaa4d
Compare
mkevinosullivan
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When sending PUT / POST requests, we were overwriting all of the headers to add the
Content-*ones, instead of extending what was set before. That meant that we were dropping theUser-Agentheader we set before.WHAT is this pull request doing?
Extending the right object after setting the PUT/POST-specific headers.
Type of change
Checklist