Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Dynamically type request responses#447

Merged
paulomarg merged 3 commits intomainfrom
allow_typing_request_responses
Aug 5, 2022
Merged

Dynamically type request responses#447
paulomarg merged 3 commits intomainfrom
allow_typing_request_responses

Conversation

@paulomarg
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Currently, when getting data from either the GraphQL or REST clients, the caller needs to manually cast the returned type which makes it more difficult than it needs to be to type the responses properly.

WHAT is this pull request doing?

Adding the option of typing the bodies of request responses when calling the appropriate methods.

Type of change

  • Minor: New feature (non-breaking change which adds functionality)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@paulomarg paulomarg requested a review from a team as a code owner August 5, 2022 15:48
@paulomarg paulomarg force-pushed the allow_typing_request_responses branch from 2d11be0 to 14512a1 Compare August 5, 2022 15:51
Comment thread src/clients/graphql/__tests__/graphql_client.test.ts Outdated
Comment thread src/clients/rest/rest_client.ts Outdated
Comment thread src/clients/graphql/graphql_client.ts
Comment thread src/clients/rest/rest_client.ts Outdated
@paulomarg paulomarg merged commit 75a91f9 into main Aug 5, 2022
@paulomarg paulomarg deleted the allow_typing_request_responses branch August 5, 2022 18:57
@shopify-shipit shopify-shipit Bot temporarily deployed to production September 19, 2022 19:28 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants