This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Automatically determine session type from token response#628
Merged
Conversation
paulomarg
force-pushed
the
auto_determine_callback_session_type
branch
from
dd8fe8b to
162b510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/first-party-library-planning/issues/507
Currently, the
auth.callbackfunction needs to be told whether or not it should expect an online or offline token, but that information is baked into the response itself.WHAT is this pull request doing?
Deprecating the
auth.callbackisOnlineparameter, since it is not necessary, and determining the session type from the token request response.Type of change
Checklist