This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Remove callback URL path check from webhook processing#629
Merged
Conversation
paulomarg
force-pushed
the
remove_callback_url_check_from_webhooks
branch
from
a100348 to
7ee82c0
Compare
paulomarg
force-pushed
the
remove_callback_url_check_from_webhooks
branch
from
7ee82c0 to
bcc91f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes #625
Closes https://github.com/Shopify/first-party-library-planning/issues/514
We're currently checking whether the received URL matches the configured path when processing webhooks, but that check fails when the webhook request is proxied.
This check was added to allow for multiple handlers for the same topic to be in the same URL, but that scenario is much less realistic than a proxied webhook call, so we should allow it.
WHAT is this pull request doing?
Removing the callback URL check when processing webhooks and the unrealistic test case.
Type of change
Checklist