This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Add processing of X-Shopify-API-Version to webhook processing#630
Merged
mkevinosullivan merged 2 commits intomainfrom Dec 8, 2022
Merged
Conversation
mkevinosullivan
force-pushed
the
kos/add_api_version_header_to_webhook_handers
branch
from
2f4d659 to
527c1c6
Compare
paulomarg
reviewed
Dec 8, 2022
paulomarg
approved these changes
Dec 8, 2022
Contributor
paulomarg
left a comment
paulomarg
left a comment
There was a problem hiding this comment.
Just one nit, but LGTM otherwise.
mkevinosullivan
force-pushed
the
kos/add_api_version_header_to_webhook_handers
branch
from
8e66d03 to
c6ca84f
Compare
mkevinosullivan
deleted the
kos/add_api_version_header_to_webhook_handers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
API library component for Shopify/shopify-app-js#29
WHAT is this pull request doing?
Add processing of
X-Shopify-API-Versionheader to webhook processing, and pass it as an optional parameter to the webhook handler.Type of change
Checklist