This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Add host param content validation using sanitizeShop regex#634
Merged
mkevinosullivan merged 1 commit intomainfrom Dec 13, 2022
Merged
Add host param content validation using sanitizeShop regex#634mkevinosullivan merged 1 commit intomainfrom
mkevinosullivan merged 1 commit intomainfrom
Conversation
mkevinosullivan
force-pushed
the
kos/validate_content_of_host
branch
from
8eac6d5 to
91dea0e
Compare
paulomarg
reviewed
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Patches a potential phishing vulnerability (Node implementation of this PR.
WHAT is this pull request doing?
sanitizeHostdecodes the host parameter and runssanitizeShopagainst it, to confirm it complies with one of the expected hostname URLs.Also adds
shopify.comas a valid domain forsanitizeShop- fixes Shopify/first-party-library-planning#516Type of change
Checklist
I have documented new APIs/updated the documentation for modified APIs (for public APIs)- not applicable