This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Fix AssignedFulfillmentOrder body parsing#644
Merged
Conversation
paulomarg
force-pushed
the
fix_assigned_fulfillment_order_fetch
branch
from
25f982f to
46f9298
Compare
paulomarg
force-pushed
the
fix_assigned_fulfillment_order_fetch
branch
from
46f9298 to
90e9d8c
Compare
cquemin
approved these changes
Dec 20, 2022
Contributor
cquemin
left a comment
cquemin
left a comment
There was a problem hiding this comment.
I can see a lot of duplication in the test data. Would there be a way to put the test data in common ?
mkevinosullivan
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #368
Fixes #642
There was a bug in the
AssignedFulfillmentOrderclass where theNAMEandPLURAL_NAMEdidn't match the actual data sent by the API.WHAT is this pull request doing?
I've updated our auto-generation code to allow overriding these values, so I'm updating the auto-generated resources here.
Type of change
Checklist