Add withSession utility method#83
Conversation
4ddf98d to
eeb940e
Compare
paulomarg
left a comment
There was a problem hiding this comment.
Looks really good overall! Had a couple of minor comments but the logic looks solid to me.
|
@paulomarg Any thoughts on the location of this code within the project? I think it would make a lot of sense to be able to call this off of |
Hm, that's an interesting question - right now I see a bit of tension between |
eeb940e to
9a6ffd1
Compare
paulomarg
left a comment
There was a problem hiding this comment.
Looks great to me. Looking for the specific errors in the test makes it much easier to see what they are actually testing too, which is a nice bonus.
9a6ffd1 to
cbdb1ca
Compare
WHAT is this pull request doing?
Adds
withSessionutil/helper. This allows the user to pass in a set of parameters and receive back a client that is already hooked into the current active session (or the requested offline session), as well as the session itself.For review, I would love extra eyes on my testing setup (all lines are covered but is there anything I should change or improve?).
Additionally, wondering if we should move this into the
clientsdirectory, as I think it would make sense to be able to callShopifyAPI.Clients.withSession(<params>)from an end-user experience perspective.