This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Use cryptographically random bytes to generate nonce#98
Merged
thecodepixi merged 1 commit intomainfrom Feb 9, 2021
Merged
Conversation
24affb2 to
e0e080c
Compare
mkevinosullivan
approved these changes
Feb 9, 2021
Contributor
|
Thank you Nicholas. I didn't realize |
thecodepixi
approved these changes
Feb 9, 2021
Contributor
thecodepixi
left a comment
There was a problem hiding this comment.
Thank you for this Nicholas! This is a much better approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The current implementation of the nonce generating function is based off of the current date (in seconds), and
Math.random.Math.randomis not cryptographically secure and as a result, the numbers can be predicted. Switching to using cryptographically random bytes to generate the nonce will allow for a more truly random numbers.WHAT is this pull request doing?
This PR makes use of node's
crypto.randomBytes()function to generate 15 random bytes. I then mod by 10 to extract the last digit from the byte and use that as a digit in the nonce.Type of change
Checklist