Fix CI failures by bumping RDoc, limiting minitest and removing outdated ERB call
#2458
+493
−332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
force-pushed
the
ko/fix-ci-6
branch
from
a49f101 to
3fee99a
Compare
We currently support Ruby 3.2 and newer in which case we can call it with kwargs https://docs.ruby-lang.org/en/3.2/ERB.html#method-c-new
KaanOzkan
changed the title
RDoc, limiting minitest and removing outdated ERB call
vinistock
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #2453
Implementation
Bump rdoc and limit Minitest until rails/rails#56202 is released
Rdoc bump triggered a ERB bump which led to a type checking error, I removed the outdated code since we don't have to support calling ERB.new without kwargs https://docs.ruby-lang.org/en/3.2/ERB.html#method-c-new
Tests