Prepping rails for minitest 6 #56202
Conversation
zenspider
force-pushed
the
zenspider__mt6
branch
2 times, most recently
from
d987d90 to
ee31f01
Compare
zenspider
force-pushed
the
zenspider__mt6
branch
7 times, most recently
from
978c7f4 to
5c51421
Compare
zenspider
changed the title
zenspider
force-pushed
the
zenspider__mt6
branch
2 times, most recently
from
f9b0ff2 to
0e2427a
Compare
MT6 changes the way assertion messages work. Now, if a proc is passed in for the message, it wins untouched. So for the rails assertions that want to have diffs shown while calling assert_equal with a message proc, the proc needs to call diff itself. This feels redundant to me, but not my call. And since the procs win now, they need to provide their own periods at the end of the text.
Mostly minor and mostly centered around whether there are diffs.
zenspider
force-pushed
the
zenspider__mt6
branch
from
0e2427a to
b58ab2a
Compare
tenderlove
left a comment
tenderlove
left a comment
There was a problem hiding this comment.
The changes seem fine, but I have a couple questions. If some of these changes are necessary, I would like to understand why. If they aren't necessary, then maybe remove them from the PR? (I don't actually mind whether or not those changes are there, I just want to know if they are there because of the upgrade to MT6)
|
|
||
| test "not being empty when route is added" do | ||
| assert_predicate self, :empty? | ||
| assert_empty @set |
There was a problem hiding this comment.
Why do these need to be changed?
There was a problem hiding this comment.
because y'all made empty? private and assert_predicate does a send on self. Breaks. assert_empty on @set passes.
| rich_message = -> do | ||
| code_string = expression.respond_to?(:call) ? _callable_to_source_string(expression) : expression | ||
| error = "`#{code_string}` changed" | ||
| error = "`#{code_string}` changed." |
There was a problem hiding this comment.
Are these periods load bearing? Why do they need to be added?
There was a problem hiding this comment.
The message helper has gotten a lot simpler/cleaner for MT6 and doesn't end sentences for you anymore. changing the error message to include the period passes on both MT5 and MT6. Otherwise I have to fight versioning on the assert_equal against the message output.
3 participants
This branch contains all the fixes needed for minitest 6 to work smoothly with rails. I've now tested extensively on MT5 as well as MT6.
I have another branch testing out the actual MT6 bump and it still has some sort of flaky going on that I'm investigating.