Update baseEnv (and associated Builder) allocation to allow for 140 Value's since we have 129 Value's in our baseEnv by default now#28
Merged
lilyinstarlight merged 1 commit intotecnix-gcsfrom Apr 29, 2026
Conversation
…alue's since we have 129 Value's in our baseEnv by default now
joshheinrichs-shopify
approved these changes
Apr 28, 2026
joshheinrichs-shopify
left a comment
joshheinrichs-shopify
left a comment
There was a problem hiding this comment.
140 builtins ought to be enough for anybody
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we have a heap buffer overflow of (at least, depending on config) 1
Valueduring every evaluator's primop registration due to our builtinsCaught by ASAN test when enabling CI checks in #27 (https://github.com/Shopify/tecnix/actions/runs/25073864562/job/73461429839?pr=27)