Skip to content

Fix CA docs cleanup (2025-10)#4317

Merged
sordaz00 merged 1 commit into2025-10from
fix/ca-docs-cleanup-2025-10
Apr 20, 2026
Merged

Fix CA docs cleanup (2025-10)#4317
sordaz00 merged 1 commit into2025-10from
fix/ca-docs-cleanup-2025-10

Conversation

@sordaz00
Copy link
Copy Markdown
Contributor

Cascaded from 2026-04. Fixes ConsentPolicy, commandFor, code formatting, and style issues.

25/26 fixes applied. shared.ts @see tags were already inlined on this branch.

Made with Cursor

@github-actions
Copy link
Copy Markdown
Contributor

🚨🚨🚨 Docs migration in progress 🚨🚨🚨

We are actively migrating UI extension reference docs to MDX in the areas/platforms/shopify-dev zone of the monorepo. This impacts docs for the following surfaces:

During this migration, please be aware of the following:

.doc.ts files are being deprecated. Changes to .doc.ts files in this repo will not be reflected in the new MDX-based docs. If you need to update docs for a reference that has already been migrated, make your changes directly in the areas/platforms/shopify-dev zone of the monorepo instead.

Doc comments in .ts source files (the comment blocks above types and functions) are also affected. Generating docs from these comments currently requires a newer version of the @shopify/generate-docs library that isn't yet available. Updates to doc comments may not produce the expected output until the migration is complete.

Examples that previously lived in this repo are being moved to the areas/platforms/shopify-dev zone of the monorepo and should be authored there going forward.

What should I do?

  • If your PR includes changes to .doc.ts files, doc comments, or examples, please reach out to us in #devtools-proj-templated-refs so we can help ensure your updates are captured correctly.
  • If your PR is limited to source code changes (non-docs), you can ignore this notice.

Thanks for your patience while we complete the migration! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

Copy link
Copy Markdown
Contributor

@mcvinci mcvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @sordaz00! Added a few minor suggestions.

export type TextAutocompleteField = ExtractStrict<AnyAutocompleteField, "additional-name" | "address-level1" | "address-level2" | "address-level3" | "address-level4" | "address-line1" | "address-line2" | "address-line3" | "country-name" | "country" | "family-name" | "given-name" | "honorific-prefix" | "honorific-suffix" | "language" | "name" | "nickname" | "one-time-code" | "organization-title" | "organization" | "postal-code" | "sex" | "street-address" | "transaction-currency" | "username" | "cc-name" | "cc-given-name" | "cc-additional-name" | "cc-family-name" | "cc-type">;
/** @publicDocs */
/**
* The policy for which buyer consent is being collected. Used by consent components to identify the type of marketing permission requested.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since consent components is a bit vague, maybe we can specifically call out the consent checkbox and consent phone field components?

disallow?: string;
/**
* Days of the week that can be selected. These intersect with the result of `allow` and `disallow`.
* Restricts which days of the week the user can select. These intersect with the result of `allow` and `disallow`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do these intersect with the result of allow and disallow? Maybe we can give a quick example?

* It’s important to note that this callback will be called only when the user **finishes editing** the date,
* and it’s called right after the `onChange` callback.
* The field is **not** validated on every change to the input. Once the buyer has signalled that
* This callback fires only when the user **finishes editing** the date, right after the `onChange` callback.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This callback fires only when the user **finishes editing** the date, right after the `onChange` callback.
* This callback fires only when the user finishes editing the date, right after the `change` callback.

* and it’s called right after the `onChange` callback.
* The field is **not** validated on every change to the input. Once the buyer has signalled that
* This callback fires only when the user **finishes editing** the date, right after the `onChange` callback.
* The field is **not** validated on every change to the input. Once the user has signalled that
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The field is **not** validated on every change to the input. Once the user has signalled that
* The field isn't validated on every change to the input. Once the user has signalled that

* Adjust the padding of all edges.
*
* - `base`: Applies padding that is appropriate for the element. Note that it may result in no padding if Shopify believes this is the right design decision in a particular context.
* - `base`: Applies padding that is appropriate for the element. This may result in no padding if Shopify determines that is the right design decision for a particular context.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* - `base`: Applies padding that is appropriate for the element. This may result in no padding if Shopify determines that is the right design decision for a particular context.
* - `base`: Applies padding that is appropriate for the element. This might result in no padding if Shopify determines that is the right design decision for a particular context.

* Disables the clickable, meaning it cannot be clicked or receive focus.
*
* In this state, onClick will not fire.
* In this state, `onClick` will not fire.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* In this state, `onClick` will not fire.
* In this state, `click` won't fire.

* @example 'customer-account.order-status.block.render'
* @see /docs/api/customer-account-ui-extensions/extension-targets-overview
* @see /docs/apps/app-extensions/configuration#targets
* Learn more about [extension targets](/docs/api/customer-account-ui-extensions/{API_VERSION}/extension-targets-overview) and [target configuration](/docs/apps/app-extensions/configuration#targets).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Learn more about [extension targets](/docs/api/customer-account-ui-extensions/{API_VERSION}/extension-targets-overview) and [target configuration](/docs/apps/app-extensions/configuration#targets).
* Learn more about [targets](/docs/api/customer-account-ui-extensions/{API_VERSION}/targets) and [target configuration](/docs/api/customer-account-ui-extensions/{API_VERSION}#configuration).

@sordaz00 sordaz00 force-pushed the fix/ca-docs-cleanup-2025-10 branch from da465ce to f037a24 Compare April 20, 2026 01:35
@sordaz00 sordaz00 merged commit 58b013f into 2025-10 Apr 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants