Skip to content

Limit admin print action shouldRender targets to details - #4656

Merged
melissaluu merged 1 commit into
2026-07from
remove-bulk-print-should-render-2026-07
Aug 27, 2026
Merged

Limit admin print action shouldRender targets to details#4656
melissaluu merged 1 commit into
2026-07from
remove-bulk-print-should-render-2026-07

Conversation

@melissaluu

Copy link
Copy Markdown
Contributor

What

Removes unsupported Admin selection print-action shouldRender targets from the 2026-07 docs/types branch.

Keeps the supported detail targets:

  • admin.order-details.print-action.should-render
  • admin.product-details.print-action.should-render

Removes unsupported selection targets:

  • admin.order-index.selection-print-action.should-render
  • admin.product-index.selection-print-action.should-render

Why

Core and Admin Web now support print-action should_render only for detail pages. The selection/bulk print-action targets should not be advertised or typed for the 2026-07 Admin UI Extensions branch.

Follow-up to the 2025-10 cleanup: #4652
World support PRs: shop/world#2016728 and shop/world#2016776

Note: the 2026-07 branch currently stores generated Admin docs under the existing 2026-07-rc generated folder, so this PR updates that tracked folder.

Testing

  • yarn workspace @shopify/ui-extensions docs:admin 2026-07-rc 2026-07-rc
  • git diff --check
  • yarn lint
  • yarn type-check

Assisted-By: devx/d6c80abe-fad1-4843-8115-86a365f713b8
@github-actions github-actions Bot added the needs-rc-port PR against a stable branch awaiting forward-port to the current RC label Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR targets a stable release branch (2026-07). Once merged, the change typically also needs to be forward-ported to 2026-10-rc so it ships in the next release.

When you open the forward-port PR, include a line like this in its body so the needs-rc-port label gets removed automatically when that PR merges:

Forward-port of #4656

Accepted formats (comma-separated for multiple):

  • #4656
  • GH-4656
  • 4656
  • https://github.com/Shopify/ui-extensions/pull/4656

If a forward-port isn't needed (e.g., the change is stable-only), you can remove the needs-rc-port label manually.

@melissaluu
melissaluu requested a review from vividviolet August 27, 2026 16:48
@melissaluu
melissaluu merged commit e52dd93 into 2026-07 Aug 27, 2026
9 checks passed
@github-actions github-actions Bot removed the needs-rc-port PR against a stable branch awaiting forward-port to the current RC label Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✓ Forward-ported in #4655.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants