This repository was archived by the owner on May 30, 2024. It is now read-only.
Avoid mutating the environment with RUBYOPT#429
Merged
Conversation
KaanOzkan
approved these changes
Mar 7, 2023
| "displayName": "Ruby LSP", | ||
| "description": "VS Code plugin for connecting with the Ruby LSP", | ||
| "version": "0.1.3", | ||
| "version": "0.1.4", |
Contributor
There was a problem hiding this comment.
I'm assuming the version bump is intentional. Maybe could be in its own commit.
Member
Author
There was a problem hiding this comment.
Fair, I split the commits. Yeah, it's intentional to get a new version with the fix out there.
vinistock
force-pushed
the
vs/avoid_mutating_environment_with_yjit
branch
from
7552df5 to
586818d
Compare
st0012
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we simply assign
env = process.env, then when we change keys inenvwe're mutatingprocess.envas well - which leaks across different extensions.This means that we append
RUBYOPT=--yjitin the process environment and it ends up applying to other extensions that spawn Ruby processes, which may lead to issues.The fix is to simply create a clone of the environment, which we can do by destructuring it inside a new object.