This repository was archived by the owner on May 30, 2024. It is now read-only.
Move environment manipulation completely to the Ruby object#440
Merged
Move environment manipulation completely to the Ruby object#440
Conversation
Member
|
I try to run the tests locally but it failed like 80% of the time. Possibly related screenshot: |
089c1b9 to
e0483b7
Compare
Member
Author
|
I think it's because I used |
st0012
reviewed
Mar 14, 2023
Member
|
@vinistock Tests now all pass locally. Thanks 👍 |
e0483b7 to
318e5ce
Compare
st0012
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The issue in #429 got me thinking about how we also mutate the environment during activation and if we manipulating it in the client made sense.
I think all environment manipulation should be contained in the
Rubyclass - since we're interested in the Ruby environment after all. This PRRubyprocess.envcompletely